This repository was archived by the owner on Jul 11, 2018. It is now read-only.
Add intermediate check for plugins when device is ready#15
Open
ridan wants to merge 1 commit intoionic-team:masterfrom
Open
Add intermediate check for plugins when device is ready#15ridan wants to merge 1 commit intoionic-team:masterfrom
ridan wants to merge 1 commit intoionic-team:masterfrom
Conversation
Author
|
@mhartington this was the PR i was talking about yesterday at the torontoJS meetup |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usually I would add all my bootstrapping logic right after this check. If the plugins object did not exist then it would throw an exception("Uncaught Type Error") and the rest of the function would not execute. This is a corner case because it would only show up on devices but unless someone is debugging with safari or chrome tools it could be totally missed.
Another case where it shows up is when you remove all plugins it still has
window.cordova.pluginsso it doesn't run anything else in that scope.