fix(angular): run change detection on attached overlay views#31235
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #31220
What is the current behavior?
Currently, a component opened through
ModalControllerthat binds a value fromcomponentPropsin its template, like<ion-nav [root]="rootPage()">, can render empty.attachViewonly runs the creation pass, so the[root]binding is applied on a later tick, afterion-navhas already finished loading and readrootas undefined. Wrapping the nav in@if (rootPage())worked around it.What is the new behavior?
After this fix,
attachViewrunsdetectChanges()on the view right after attaching it, so template bindings apply before the web component loads.ion-navnow sees itsrootduring load and renders it. This matches thedetectChangescall already onmajor-9.0.Does this introduce a breaking change?
Other information
The actual fix for this PR is fairly small, most of it is just testing. It's also important to note that this is already fixed in v9 in the same exact way, we're just backporting it to v8 here.
Dev build: