-
Notifications
You must be signed in to change notification settings - Fork 3.2k
docs(config): add code snippets of how to access the mode per framework #4172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@joesphchang is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Does this PR replace #4147? If so, can we close that one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on this! I've suggested a few changes to simplify the examples. Our goal is to make it easy for users to quickly spot and access the relevant code to get the mode at a glance.
I've tested the requested changes locally, but there might be a stray copy/paste issue or a need to run npm lint
. Let me know if you have any questions!
I made those suggested changes and committed them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making those changes! I made a small tweak to the demo/JS examples to add a space between Current mode:
and the actual mode. It was just something that I didn't notice before that bothered me. Everything else looks great! 🙂
Resolves #2580
Added ionic-mode to the appropriate section in Config
Preview