Skip to content

Conversation

@mlipok
Copy link
Contributor

@mlipok mlipok commented Jan 17, 2026

UDF begining

@ioa747 please take a look and give me what you think about such concept for UDF

Remark:
temporary NetWebView2Lib.au3 file contains UDF and example all together within separate regions.

@mlipok mlipok changed the title NetWebView2Lib.au3 creation NetWebView2Lib.au3 UDF - creation Jan 17, 2026
@ioa747 ioa747 marked this pull request as ready for review January 18, 2026 00:21
@ioa747 ioa747 merged commit 1f54dec into ioa747:main Jan 18, 2026
@mlipok
Copy link
Contributor Author

mlipok commented Jan 18, 2026

@ioa747
thanks for merging

Please for next time note that I make it as Draft.
I wanted to take feadback first, especially in the places when I started review
image

so please make your remark in each review.

If you find other places in code you can review them too.

@mlipok
Copy link
Contributor Author

mlipok commented Jan 18, 2026

However, since you've already accepted, I'll move forward with corrections/proposals in future PRs.

Let's finish the discussion here as well.

@mlipok mlipok deleted the UDF-creation branch January 18, 2026 00:56
@ioa747
Copy link
Owner

ioa747 commented Jan 18, 2026

Hi @mlipok,

Please excuse the quick merge. To be honest, I'm still learning the ropes of GitHub's workflow, and I didn't quite understand the difference between a 'Draft' and a regular PR, or how the 'Review' process works. I thought I was just accepting your contribution!
Thanks for your patience

@mlipok
Copy link
Contributor Author

mlipok commented Jan 18, 2026

Please excuse the quick merge. To be honest, I'm still learning the ropes of GitHub's workflow, and I didn't quite understand the difference between a 'Draft' and a regular PR, or how the 'Review' process works. I thought I was just accepting your contribution! Thanks for your patience

no problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants