Skip to content

fix: Annotate as error if fatal #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: Annotate as error if fatal #222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
92caeb5
Annotate as error if fatal
kzrnm Feb 19, 2024
8c9b5d8
Merge branch 'main' into fatal_log
Salakar Feb 27, 2024
9dca256
Rebuild
kzrnm Feb 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions dist/index.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/index.js.map
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,8 @@ async function run(): Promise<void> {
for (const info of result.infos) {
core.info(getProblemLogMessage(info, !options.annotate));
if (options.annotate) {
core.notice(
const annotate = options.fatalInfos ? core.error : core.notice;
annotate(
getAnnotationMessage(info),
getProblemAnnotationProperties(info),
);
Expand All @@ -85,7 +86,8 @@ async function run(): Promise<void> {
for (const warning of result.warnings) {
core.info(getProblemLogMessage(warning, !options.annotate));
if (options.annotate) {
core.warning(
const annotate = options.fatalWarnings ? core.error : core.warning;
annotate(
getAnnotationMessage(warning),
getProblemAnnotationProperties(warning),
);
Expand Down