site: add collections rules#429
Merged
kpsherva merged 2 commits intoinveniosoftware:masterfrom Mar 25, 2026
Merged
Conversation
Contributor
jrcastro2
commented
Jan 21, 2026
jrcastro2
commented
- closes 5 - Implement full collections management + Browse tab visibility rules CERNDocumentServer/cds-rdm#632
jrcastro2
force-pushed
the
add-collections-style
branch
from
959b7d7 to
91ed965
Compare
jrcastro2
force-pushed
the
add-collections-style
branch
from
4c18b4d to
4c68c3a
Compare
OliverGeneser
requested changes
Feb 13, 2026
Comment on lines
+720
to
+744
| /*------------------------- | ||
| <<<<<<< Updated upstream | ||
| Collections Table Styling | ||
| ======= | ||
| Job Logs Styling | ||
| -------------------------*/ | ||
|
|
||
| /* Log table container */ | ||
| .job-log-table { | ||
| max-height: 80vh; | ||
| overflow-y: auto; | ||
|
|
||
| /* Subtask container - subtle indentation for subtask logs without border */ | ||
| .subtask-container { | ||
| padding: 0.5em; | ||
| margin: 0.5em 0 0.5em 1em; | ||
| background-color: #fafafa; | ||
| } | ||
| } | ||
|
|
||
| /*------------------------- | ||
| Collections Styling | ||
| >>>>>>> Stashed changes | ||
| (Used by invenio-communities) | ||
| -------------------------*/ |
Contributor
Author
There was a problem hiding this comment.
Right, thx, also removed some more code that is not needed, thx for this.
Member
|
I'm wondering if we could rely more on Semantic UI and write a bit less CSS? |
Contributor
Author
Most of the CSS is for the drag and drop, and to reproduce the browse style page, in general I tried to stick to SUI as much as I could. Happy to hear some improvements or alternatives :) |
jrcastro2
force-pushed
the
add-collections-style
branch
from
4c68c3a to
a6d3d10
Compare
kpsherva
reviewed
Mar 17, 2026
jrcastro2
force-pushed
the
add-collections-style
branch
from
a6d3d10 to
2f4cfea
Compare
kpsherva
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.