Skip to content

[BUGFIX] Remove Mutable Default Arguments #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions interfax/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,14 +65,25 @@ def account(self):
def deliver(self):
return self.outbound.deliver

def get(self, path, params={}, valid_keys=[], **kwargs):
def get(self, path, params=None, valid_keys=None, **kwargs):
"""Make a HTTP GET request."""
if params is None:
params = {}

if valid_keys is None:
valid_keys = []

url = self._url_for(path, params, valid_keys)
return self._request('GET', url, **kwargs)

def post(self, path, params={}, valid_keys=[], **kwargs):
def post(self, path, params=None, valid_keys=None, **kwargs):
"""Make a HTTP POST request."""
if params is None:
params = {}

if valid_keys is None:
valid_keys = []

url = self._url_for(path, params, valid_keys)
return self._request('POST', url, **kwargs)

Expand All @@ -89,8 +100,14 @@ def _request(self, method, url, **kwargs):

return self._parse_response(request(method, url, **kwargs))

def _url_for(self, path, params={}, keys=[]):
def _url_for(self, path, params=None, keys=None):
"""Validate query params and return fully qualified url."""
if params is None:
params = {}

if keys is None:
keys = []

invalid = [k for k in params if k not in keys]

message = 'unexpected keyword argument "{0}", expecting: {1}'
Expand Down