Fix node failure reason reporting. #1665
Merged
+15
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing#1659) * add pkill when stopping worker timeout * debug ut * fix ut
BalaBalaYi
requested review from
majieyue,
samplise and
workingloong
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1665 +/- ##
=======================================
Coverage 80.26% 80.27%
=======================================
Files 225 225
Lines 22146 22150 +4
=======================================
+ Hits 17776 17781 +5
+ Misses 4370 4369 -1 ☔ View full report in Codecov by Sentry. |
BalaBalaYi
merged commit 235cee6
into
intelligent-machine-learning:master
11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Override node exit reason by self detected reason.
Why are the changes needed?
Fix: detected exit reason not reported
Does this PR introduce any user-facing change?
No
How was this patch tested?
Training test with node check failed case.