Training hang detection based on XPU Timer metric. #1288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BalaBalaYi
requested review from
majieyue,
samplise and
workingloong
as code owners
dlrover/python/diagnosis/inferencechain/inferenceoperator/check_training_hang_operator.py
Show resolved
Hide resolved
dlrover/python/diagnosis/inferencechain/inferenceoperator/check_training_hang_operator.py
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1288 +/- ##
==========================================
+ Coverage 80.86% 81.02% +0.15%
==========================================
Files 229 230 +1
Lines 21540 21788 +248
==========================================
+ Hits 17418 17653 +235
- Misses 4122 4135 +13 ☔ View full report in Codecov by Sentry. |
# Conflicts: # dlrover/python/diagnosis/common/constants.py # dlrover/python/diagnosis/common/diagnosis_action.py # dlrover/python/elastic_agent/torch/training.py # dlrover/python/master/node/job_manager.py # dlrover/python/master/servicer.py # dlrover/python/tests/test_diagnosis.py # dlrover/python/tests/test_diagnosis_agent.py # dlrover/python/tests/test_job_manager.py # dlrover/python/util/time_util.py
# Conflicts: # dlrover/python/diagnosis/common/diagnosis_action.py # dlrover/python/diagnosis/inferencechain/inferenceoperator/check_training_hang_operator.py # dlrover/python/tests/test_diagnosis.py
BalaBalaYi
changed the title
samplise
reviewed
Nov 12, 2024
...r/python/diagnosis/inferencechain/inferenceoperator/observer/check_training_hang_operator.py
Outdated
Show resolved
Hide resolved
...r/python/diagnosis/inferencechain/inferenceoperator/observer/check_training_hang_operator.py
Show resolved
Hide resolved
...r/python/diagnosis/inferencechain/inferenceoperator/observer/check_training_hang_operator.py
Outdated
Show resolved
Hide resolved
...r/python/diagnosis/inferencechain/inferenceoperator/observer/check_training_hang_operator.py
Outdated
Show resolved
Hide resolved
samplise
approved these changes
Nov 13, 2024
samplise
merged commit 07b18ac
into
intelligent-machine-learning:master
13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
CheckTrainingHangOperatorbased on XPU Timer metric to detect training hang.ResolveTrainingHangOperatorto determine what to do if training hang.Dequeinstead ofQueueinDiagnosisDataManager.Why are the changes needed?
Training hang detection POC.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
UT.