Skip to content

Conversation

@samplise
Copy link
Collaborator

What changes were proposed in this pull request?

Refactor diagnosis agent. The agent will observe the problems periodically.

Why are the changes needed?

Complete the framework that the agent could check if predefined problems happen.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Unit test

@codecov
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 95.30201% with 7 lines in your changes missing coverage. Please review.

Project coverage is 80.31%. Comparing base (1936f1d) to head (cf40a3c).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
.../python/elastic_agent/diagnosis/diagnosis_agent.py 87.50% 4 Missing ⚠️
dlrover/python/diagnosis/common/diagnose_action.py 83.33% 1 Missing ⚠️
...n/inferenceoperator/metrics_collection_operator.py 95.45% 1 Missing ⚠️
...over/python/tests/test_diagnosis_data_collector.py 98.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1287      +/-   ##
==========================================
+ Coverage   80.19%   80.31%   +0.11%     
==========================================
  Files         218      222       +4     
  Lines       20336    20429      +93     
==========================================
+ Hits        16309    16408      +99     
+ Misses       4027     4021       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samplise samplise changed the title WIP: refactor diagnosis agent Refactor diagnosis agent Oct 11, 2024
Copy link
Collaborator

@BalaBalaYi BalaBalaYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samplise samplise merged commit f10ba6c into intelligent-machine-learning:master Oct 12, 2024
13 checks passed
@BalaBalaYi BalaBalaYi added this to the v0.4.0 milestone Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants