Skip to content

Conversation

@BalaBalaYi
Copy link
Collaborator

What changes were proposed in this pull request?

  1. Use a async thread to collect metric periodically.
  2. Pre process and report the metric to master.
  3. Refactor the implementation of 'diagnosis_data'.
  4. Other optimization.

Why are the changes needed?

To support training hang detection later.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

UT.

@codecov
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 84.16988% with 41 lines in your changes missing coverage. Please review.

Project coverage is 80.15%. Comparing base (f03b769) to head (0613676).
Report is 21 commits behind head on master.

Files with missing lines Patch % Lines
.../inferenceoperator/check_training_hang_operator.py 50.00% 8 Missing ⚠️
dlrover/python/master/servicer.py 36.36% 7 Missing ⚠️
dlrover/python/diagnosis/common/diagnosis_data.py 90.62% 6 Missing ⚠️
.../python/elastic_agent/diagnosis/diagnosis_agent.py 78.57% 6 Missing ⚠️
...gnosis/datacollector/xpu_timer_metric_collector.py 83.87% 5 Missing ⚠️
dlrover/python/elastic_agent/torch/training.py 20.00% 4 Missing ⚠️
dlrover/python/master/diagnosis/diagnosis.py 75.00% 2 Missing ⚠️
...r/python/diagnosis/datacollector/data_collector.py 50.00% 1 Missing ⚠️
dlrover/python/elastic_agent/master_client.py 66.66% 1 Missing ⚠️
dlrover/python/tests/test_diagnosis_agent.py 98.18% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1285      +/-   ##
==========================================
- Coverage   80.48%   80.15%   -0.33%     
==========================================
  Files         219      218       -1     
  Lines       20208    20326     +118     
==========================================
+ Hits        16264    16292      +28     
- Misses       3944     4034      +90     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@samplise samplise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@samplise samplise merged commit afe0ea8 into intelligent-machine-learning:master Oct 10, 2024
13 checks passed
@BalaBalaYi BalaBalaYi added this to the v0.4.0 milestone Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants