UpsampleBilinear2Daa: Correct the global range #1942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Removes the artificial limit on logical threads in grid computation for SYCL upsample bilinear 2D kernels. The change eliminates the use of syclMaxWorkItemsPerTile() to cap the total threads, allowing the grid dimensions to be computed directly based on output dimensions and batch/channel counts.
- Removes
total_threadsvariable and associated limiting logic in grid computation - Simplifies grid dimension calculations to use actual requirements without thread limits
- Updates both forward and backward kernel launch functions
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
CuiYifeng
approved these changes
Aug 21, 2025
|
Please correct the PR comment. |
done |
fengyuan14
changed the title
fengyuan14
approved these changes
Aug 25, 2025
CuiYifeng
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct the global range. The global range should be multiples of work group size.
Fix #1465