-
Notifications
You must be signed in to change notification settings - Fork 46
Print SYCL build options in building #1779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
xytintel
wants to merge
3
commits into
main
Choose a base branch
from
xyt/sycl_build_status
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunhuanMeng
approved these changes
Jun 25, 2025
@sys_pytorchxpubot triage result for run 15866674343Triage bot UT analaysis result for reference only, please note unique error message only report once:
Triage bot response: {
"similar_issue_id": "570",
"similar_issue_state": "closed",
"issue_owner": "fengyuan14",
"issue_description": "The reporter, ZzEeKkAa, encountered a NotImplementedError while running Intel's Triton unit tests with upstream PyTorch. The error message indicated that the operator 'aten::__lshift__.Scalar' is not implemented for the XPU device. The reporter was advised to either open a feature request or use a CPU fallback by setting the environment variable `PYTORCH_ENABLE_XPU_FALLBACK=1`.",
"root_causes": [
"The shift operators were not initially supported in the XPU implementation plan, but were added later based on community feedback and requirements."
],
"suggested_solutions": [
"Update torch-xpu-ops to ensure all relevant operations, including those for complex numbers, are implemented and optimized for XPU.",
"Adjust test thresholds to account for potential precision differences in XPU computations.",
"Implement specific optimizations for complex number determinant calculations on XPU if they are missing."
]
}
Triage bot response: {
"similar_issue_id": 1214,
"similar_issue_state": "open",
"issue_owner": "daisyden",
"issue_description": "The test test_tensorsolve_xpu_complex128 failed with an AssertionError: Tensor-likes are not close! The error suggests a discrepancy in tensor values between CPU and XPU during the linalg operation, possibly due to numerical precision or kernel behavior differences.",
"root_causes": [
"Discrepancies in numerical computations between CPU and XPU implementations.",
"Potential differences in kernel behavior affecting complex128 precision."
],
"suggested_solutions": [
"Enhance numerical precision checks in the linalg operations for XPU.",
"Review and align kernel behavior to ensure consistency across CPU and XPU.",
"Implement additional tests to validate tensor computations across different scenarios."
]
}
Triage bot response: {
"similar_issue_id": 264,
"similar_issue_state": "closed",
"issue_owner": "torch-xpu-ops maintainers",
"issue_description": "The test `test_fn_grad_linalg_eigvals_xpu_float64` failed with an error involving a tensor of size (5,5) on the XPU device with dtype float64. The failure suggests an issue with the implementation of `linalg.eigvals` for float64 tensors on XPU, potentially related to dtype handling or missing kernel support.",
"root_causes": [
"Inadequate support for float64 dtype in `linalg.eigvals` on XPU.",
"Potential missing or incorrect implementation of the XPU kernel for `linalg.eigvals` with float64 tensors."
],
"suggested_solutions": [
"Implement the `linalg.eigvals` function for float64 tensors on XPU.",
"Ensure proper dtype handling and kernel support for float64 in XPU operations.",
"Add comprehensive tests to verify the correctness of `linalg.eigvals` across various dtypes on XPU."
]
}
Triage bot response: {
"similar_issue_id": 1214,
"similar_issue_state": "open",
"issue_owner": "daisyden",
"issue_description": "The test `test_numpy_ref_linalg_tensorsolve_xpu_complex128` failed with an `AssertionError: Tensor-likes are not close!` error. This indicates a discrepancy between the test's expected result and the actual output, specifically for complex128 tensors. The failure may stem from differences in how `linalg_tensorsolve` operates on XPU compared to expected behavior, potentially related to precision or implementation specifics.",
"root_causes": [
"Discrepancies in `linalg_tensorsolve` operation between XPU and expected results, possibly due to differences in handling complex128 tensors.",
"Potential alignment issues in the implementation of `linalg_tensorsolve` on XPU compared to other devices."
],
"suggested_solutions": [
"Review and adjust the implementation of `linalg_tensorsolve` on XPU to align with expected behavior, focusing on complex128 dtype handling.",
"Add additional checks or adjust precision settings to ensure consistency across different devices for complex operations."
]
} |
EikanWang
reviewed
Jun 30, 2025
dvrogozh
reviewed
Jun 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not against this PR, but imho, we need to just have a way to print executed cmdlines in the log. Preferably following same set of options when printing C/C++ cmdlines, i.e. VERBOSE=1
and such.
Co-authored-by: Eikan Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Print SYCL options in building