Refactor and docs: fix typo, reformat code, update README#1009
Open
v1k1nghawk wants to merge 1 commit intointel:masterfrom
Open
Refactor and docs: fix typo, reformat code, update README#1009v1k1nghawk wants to merge 1 commit intointel:masterfrom
v1k1nghawk wants to merge 1 commit intointel:masterfrom
Conversation
v1k1nghawk
commented
Apr 1, 2026
v1k1nghawk
commented
- Fix typo in print_output()
- Convert indentation from tabs to spaces for consistency (according to project's Coding Style)
- Update README.md to include more user-friendly robust instructions for build directory creation, otherwise, if a user would like to repeat the step they will get an error: "mkdir: cannot create directory ‘build’: File exists" because the directory persists from a previous attempt
- Fix typo in print_output() - Convert indentation from tabs to spaces for consistency (according to project's Coding Style) - Update README.md to include more robust instruction for build directory creation
ogbrugge
reviewed
Apr 1, 2026
|
|
||
| ``` | ||
| mkdir build | ||
| rm -rf build && mkdir build |
Contributor
There was a problem hiding this comment.
It is probably good to mention here that one can use mkdir -p here to prevent a full rebuild. If one wants a full rebuild then delete it all and start over.
Contributor
|
Regarding the rest of the changes, I've discussed this with @rdementi in the past but it is probably better to change indentation only there where you make actual changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.