[SYCL] Use unsigned int limit for -fsycl-id-queries-fit-in-int#21656
Draft
againull wants to merge 1 commit intointel:syclfrom
Draft
[SYCL] Use unsigned int limit for -fsycl-id-queries-fit-in-int#21656againull wants to merge 1 commit intointel:syclfrom
againull wants to merge 1 commit intointel:syclfrom
Conversation
Change the fit-in-int optimization to use UINT_MAX instead of INT_MAX as the limit for SYCL ID queries. This allows the full unsigned range for work-item IDs, which are non-negative. I.e. this optimization is based on the assumption that values will fit in i32, but since these values are unsigned there is no reason to check for signed integer limits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the fit-in-int optimization to use UINT_MAX instead of INT_MAX as the limit for SYCL ID queries. This allows the full unsigned range for work-item IDs, which are non-negative.
I.e. this optimization is based on the assumption that values will fit in i32, but since these values are unsigned there is no reason to check for signed integer limits.