[CI][SYCL][Test] Make `check-sycl-unittests` also run unit tests with ABI breaking changes. #19687

uditagarwal97 · 2025-08-01T20:49:08Z

This PR makes check-sycl-unittests CMake target run both preview and non-preview version of unit tests.

…eaking changes enabled.

sycl/cmake/modules/AddSYCLUnitTestPreview.cmake

sarnex

cmake lgtm

sarnex · 2025-08-04T23:59:02Z

sycl/cmake/modules/AddSYCLUnitTest.cmake


  if(WIN32)
    # Windows doesn't support LD_LIBRARY_PATH, so instead we copy the mock OpenCL binary next to the test and ensure
    # that the test itself links to OpenCL (rather than through ur_adapter_opencl.dll)
    set(mock_ocl ${CMAKE_CURRENT_BINARY_DIR}/OpenCL.dll)
+
+    # An error is thrown if both the preview and non-preview versions try to


unrelated but do we really need to copy the opencl library to the test dir?

I think so. Before my changes, there was a comment (https://github.com/intel/llvm/blob/sycl/sycl/cmake/modules/AddSYCLUnitTest.cmake#L79) saying:

# Windows doesn't support LD_LIBRARY_PATH, so instead we copy the mock OpenCL binary next to the test and ensure # that the test itself links to OpenCL (rather than through ur_adapter_opencl.dll)

aelovikov-intel · 2025-08-05T14:21:14Z

.github/workflows/sycl-linux-build.yml

+    - name: check-sycl-unittests-preview
+      if: always() && !cancelled() && contains(inputs.changes, 'sycl')
+      run: |
+        # TODO consider moving this to Dockerfile.
+        export LD_LIBRARY_PATH=/usr/local/cuda/compat/:/usr/local/cuda/lib64:$LD_LIBRARY_PATH
+        cmake --build $GITHUB_WORKSPACE/build --target check-sycl-unittests-preview


IMO, existing target should just check both.

Do you mean that check-sycl-unittests should check both preview and non-preview?
OR
Was you comment specific to the CI job, like a single job for both preview and non-preview unittest run?

check-sycl-unittests should check both preview and non-preview.

Done in 22d66d0

aelovikov-intel · 2025-08-06T16:55:26Z

sycl/cmake/modules/AddSYCLUnitTest.cmake

+    endif()
+  endif()
+
+  # This is done to ensure that preview tests are kept in a seperate


Suggested change

# This is done to ensure that preview tests are kept in a seperate

# This is done to ensure that preview tests are kept in a separate

[SYCL][Test] Add CMake target for running SYCL unit tests with ABI br…

b21e042

…eaking changes enabled.

uditagarwal97 had a problem deploying to WindowsCILock August 1, 2025 20:49 — with GitHub Actions Failure

uditagarwal97 self-assigned this Aug 1, 2025

uditagarwal97 added 2 commits August 2, 2025 00:24

Use CMake's copy_if_different to avoid build rule collision

2bf9225

Run unittests in preview mode in CI

e5e5812

uditagarwal97 had a problem deploying to WindowsCILock August 1, 2025 22:28 — with GitHub Actions Failure

uditagarwal97 requested a review from Copilot August 1, 2025 22:52

This comment was marked as outdated.

Sign in to view

Fix windows

7032e8c

uditagarwal97 temporarily deployed to WindowsCILock August 2, 2025 18:22 — with GitHub Actions Inactive

uditagarwal97 temporarily deployed to WindowsCILock August 2, 2025 18:23 — with GitHub Actions Inactive

uditagarwal97 temporarily deployed to WindowsCILock August 2, 2025 18:49 — with GitHub Actions Inactive

uditagarwal97 temporarily deployed to WindowsCILock August 2, 2025 19:02 — with GitHub Actions Inactive

aelovikov-intel reviewed Aug 4, 2025

View reviewed changes

sycl/cmake/modules/AddSYCLUnitTestPreview.cmake Outdated Show resolved Hide resolved

Code reuse between preview and non-preview unittests

63f00e6

uditagarwal97 had a problem deploying to WindowsCILock August 4, 2025 18:23 — with GitHub Actions Error

uditagarwal97 had a problem deploying to WindowsCILock August 4, 2025 18:24 — with GitHub Actions Error

NFC changes, remove incorrect comments, add space at EOF

e3fb020

uditagarwal97 had a problem deploying to WindowsCILock August 4, 2025 18:26 — with GitHub Actions Failure

uditagarwal97 temporarily deployed to WindowsCILock August 4, 2025 18:26 — with GitHub Actions Inactive

Don't call unittest preview from non-preview call

8b63e12

uditagarwal97 temporarily deployed to WindowsCILock August 4, 2025 18:53 — with GitHub Actions Inactive

uditagarwal97 temporarily deployed to WindowsCILock August 4, 2025 19:11 — with GitHub Actions Inactive

Update unittests CMakefile to explicitly specify preview target

f8b3633

uditagarwal97 had a problem deploying to WindowsCILock August 4, 2025 23:11 — with GitHub Actions Error

uditagarwal97 had a problem deploying to WindowsCILock August 4, 2025 23:12 — with GitHub Actions Error

uditagarwal97 requested a review from aelovikov-intel August 4, 2025 23:13

uditagarwal97 temporarily deployed to WindowsCILock August 4, 2025 23:29 — with GitHub Actions Inactive

uditagarwal97 marked this pull request as ready for review August 4, 2025 23:30

uditagarwal97 requested review from a team as code owners August 4, 2025 23:30

uditagarwal97 requested a review from reble August 4, 2025 23:30

uditagarwal97 temporarily deployed to WindowsCILock August 4, 2025 23:58 — with GitHub Actions Inactive

sarnex approved these changes Aug 4, 2025

View reviewed changes

sarnex requested a review from a team August 4, 2025 23:59

uditagarwal97 temporarily deployed to WindowsCILock August 5, 2025 00:02 — with GitHub Actions Inactive

aelovikov-intel reviewed Aug 5, 2025

View reviewed changes

Make check-sycl-unittests check both prevew and non-preview versions

22d66d0

uditagarwal97 temporarily deployed to WindowsCILock August 6, 2025 15:07 — with GitHub Actions Inactive

uditagarwal97 changed the title ~~[CI][SYCL][Test] Add CMake target for running SYCL unit tests with ABI breaking changes enabled~~ [CI][SYCL][Test] Make check-sycl-unittests also run unit tests with ABI breaking changes. Aug 6, 2025

uditagarwal97 temporarily deployed to WindowsCILock August 6, 2025 15:49 — with GitHub Actions Inactive

uditagarwal97 requested a review from aelovikov-intel August 6, 2025 16:07

Implicitly create two targets, with and without preview

f6b8ff0

uditagarwal97 had a problem deploying to WindowsCILock August 6, 2025 16:48 — with GitHub Actions Error

aelovikov-intel approved these changes Aug 6, 2025

View reviewed changes

Remove extra s from make target

61d5b01

uditagarwal97 had a problem deploying to WindowsCILock August 6, 2025 16:59 — with GitHub Actions Error

Remove unrelated formatting changes.

ae27b3d

uditagarwal97 temporarily deployed to WindowsCILock August 6, 2025 17:07 — with GitHub Actions Inactive

uditagarwal97 temporarily deployed to WindowsCILock August 6, 2025 17:36 — with GitHub Actions Inactive

adamfidel approved these changes Aug 6, 2025

View reviewed changes

uditagarwal97 merged commit 2443f54 into sycl Aug 6, 2025
51 of 53 checks passed

uditagarwal97 deleted the private/udit/preview_unittest branch August 6, 2025 21:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[CI][SYCL][Test] Make `check-sycl-unittests` also run unit tests with ABI breaking changes. #19687

[CI][SYCL][Test] Make `check-sycl-unittests` also run unit tests with ABI breaking changes. #19687

Uh oh!

uditagarwal97 commented Aug 1, 2025 •

edited

Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

sarnex left a comment

Uh oh!

sarnex Aug 4, 2025

Uh oh!

uditagarwal97 Aug 5, 2025

Uh oh!

aelovikov-intel Aug 5, 2025

Uh oh!

uditagarwal97 Aug 5, 2025

Uh oh!

aelovikov-intel Aug 5, 2025

Uh oh!

uditagarwal97 Aug 6, 2025

Uh oh!

aelovikov-intel Aug 6, 2025

Uh oh!

Uh oh!

Uh oh!

	# This is done to ensure that preview tests are kept in a seperate
	# This is done to ensure that preview tests are kept in a separate

[CI][SYCL][Test] Make check-sycl-unittests also run unit tests with ABI breaking changes. #19687

[CI][SYCL][Test] Make check-sycl-unittests also run unit tests with ABI breaking changes. #19687

Uh oh!

Conversation

uditagarwal97 commented Aug 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

sarnex left a comment

Choose a reason for hiding this comment

Uh oh!

sarnex Aug 4, 2025

Choose a reason for hiding this comment

Uh oh!

uditagarwal97 Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

aelovikov-intel Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

uditagarwal97 Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

aelovikov-intel Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

uditagarwal97 Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

aelovikov-intel Aug 6, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

[CI][SYCL][Test] Make `check-sycl-unittests` also run unit tests with ABI breaking changes. #19687

[CI][SYCL][Test] Make `check-sycl-unittests` also run unit tests with ABI breaking changes. #19687

uditagarwal97 commented Aug 1, 2025 •

edited

Loading