[SYCL][Test] Fix mock calls in render-group test #19685
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhance the mock library used in the render-group SYCL test to support both standard and large file variants (glob, glob64, open, open64, globfree, globfree64). When large file support is enabled in the build, the mock library now correctly provides the required *64 symbols. Additionally, if files are not /dev/dri/renderD* then fallback to the real library functions, preserving rest of the sycl-ls functionality. This improves reliability across different build configurations.
| pglob->gl_pathc = 0; | ||
| pglob->gl_pathv = NULL; | ||
| return 0; | ||
| } |
There was a problem hiding this comment.
Should we apply
Additionally, if files are not /dev/dri/renderD* then fallback to the real library functions, preserving rest of the sycl-ls functionality.
here as well?
There was a problem hiding this comment.
I'd also move "/dev/dri/renderD128" to a global constant pointer, so that we could simply compare pglob->gl_pathv[0] == global_render_d128_const in the globfree to decide if we need to delegate it to a real implementation or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance the mock library used in the render-group SYCL test to support both standard and large file variants (glob, glob64, open, open64, globfree, globfree64).
When large file support is enabled in the build, the mock library now correctly provides the required "*64" symbols. Additionally, if files are not
/dev/dri/renderD*then fallback to the real library functions, preserving rest of the sycl-ls functionality.This improves reliability across different build configurations.