Skip to content

[GDB] Fix pretty-printer crash for sycl::item MOffset #19683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: sycl
Choose a base branch
from
Open

[GDB] Fix pretty-printer crash for sycl::item MOffset #19683

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions sycl/gdb/libsycl.so-gdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1074,10 +1074,13 @@ def to_string(self):
string = self.type_name(self.gdb_type())
extent = SYCLRangePrinter(sycl_item.extent()).value_as_string()
string += " range " + extent
offset_id = SYCLItem(self.gdb_value()).offset()
offset = SYCLIdPrinter(offset_id).value_as_string()
if offset not in ["0", "{0, 0}", "{0, 0, 0}"]:
string += ", offset " + offset
try:
offset_id = SYCLItem(self.gdb_value()).offset()
offset = SYCLIdPrinter(offset_id).value_as_string()
if offset not in ["0", "{0, 0}", "{0, 0, 0}"]:
string += ", offset " + offset
except:
Copy link
Preview

Copilot AI Aug 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a bare 'except:' clause catches all exceptions including system errors like KeyboardInterrupt. Consider catching specific exceptions like AttributeError or KeyError, or use 'except Exception:' to avoid catching system exceptions.

Suggested change
except:
except Exception:

Copilot uses AI. Check for mistakes.

pass # device offset disabled
Copy link
Preview

Copilot AI Aug 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment 'device offset disabled' is misleading. Based on the PR description, this handles cases where offset has been disabled/deprecated in SYCL 2020, not specifically device offset. Consider updating to '# offset feature disabled (deprecated in SYCL 2020)' for clarity.

Suggested change
pass # device offset disabled
pass # offset feature disabled (deprecated in SYCL 2020)

Copilot uses AI. Check for mistakes.

string += " = " + self.value_as_string()
return string

Expand Down