-
Notifications
You must be signed in to change notification settings - Fork 797
[SYCL][NFCI] Move abs and div to cstdlib header #19671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: sycl
Are you sure you want to change the base?
Conversation
These functions are declared in cmath and use data type defined in cstdlib. Some cmath implementations include cstdlib implicitly, but not all of them. Moving declarations to a standalone header removes dependency on cmath implementation.
Remove std::div and std::abs overloads and remove xfail mark for the test. Align cstdlib declaration with cppreference: 1. Make all declarations overloadable. 2. Fix function name for div(long long, long long) overload and add missing overload. 3. Add std::* variants.
run_prebuilt_e2e_tests (E2E tests on Intel Ponte Vecchio GPU, ["Linux", "pvc"], -u 1001 --device=... / E2E tests on Intel Ponte Vecchio GPU failure doesn't seem to be related to the change. The test doesn't use |
Hi, @bader |
There is no sense in making any changes for OpenMP offloading in this repository because OpenMP offloading is not supported/tested here. In the upstream OpenMP offloading uses clang's headers to implement @sarnex, are you working on something similar in the upstream? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will conflict with #19620. Can you apply the changes here I did to these functions, I don't want it to be lost during conflict resolution.
I haven't begun to think about how we will deal with libdevice in OMP upstream, however I agree we should match whatever the community does as best as possible. |
These functions are declared in cmath and use data type defined in
cstdlib. Some cmath implementations include cstdlib implicitly, but
not all of them. Moving declarations to a standalone header removes
dependency on cmath implementation.