[SYCL][UR] Improve support for preinstalled OpenCL deps #19649
+117
−131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unify OpenCL detection logic to improve packaging for Linux distros.
Right now two different projects,
opencl-aotand the UR OCL plugin depend on OpenCL (both the headers and the ICD loader)They both have their own detection logic and CMake variables to use a preinstalled version.
Move the detection logic to using the standard
find_packageand unify the logic.There are now no CMake variables to specify the repo, commit or install directory. If
find_packagefiles because the install is in a weird location, the user should add the path toCMAKE_MODULE_PATH.Improvement of our OpenCL handling was directly requested by NixOS developers, see below issue.
Issue: #19635