Skip to content

[UR][L0] Set kernel arguments only for queue's associated device #19647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: sycl
Choose a base branch
from

Conversation

againull
Copy link
Contributor

Ensure that kernel arguments are set only for the device associated
with the queue being used for kernel launch. Previously, arguments
were set for all devices in the kernel's device map, which was
unnecessary and potentially incorrect when launching on a specific
device.

Logic to set kernel arguments was moved to helper EnqueueKernelLaunchCommon
to avoid retrieving L0 kernel handle multiple times.

againull added 2 commits July 30, 2025 14:49
Ensure that kernel arguments are set only for the device associated
with the queue being used for kernel launch. Previously, arguments
could be set for all devices in the kernel's device map, which was
unnecessary and potentially incorrect when launching on a specific
device.

Logic to set kernel arguments was moved to helper `EnqueueKernelLaunchCommon`
to avoid retrieving L0 kernel handle multiple times.
Set kernel arguments via new methods of single device kernel object.
@againull
Copy link
Contributor Author

againull commented Jul 30, 2025

@pbalcer @igchor even though GSD-11346 is reopened, it still seems useful to make changes in the adapter to set arguments only for a device associated with the queue (now that we have api to enqueue/setarg at the same time). What do you think? If you agree, I can follow up with this PR. Otherwise I am going to abandon this PR and wait for the fix in the L0 runtime.

@pbalcer
Copy link
Contributor

pbalcer commented Jul 31, 2025

@pbalcer @igchor even though GSD-11346 is reopened, it still seems useful to make changes in the adapter to set arguments only for a device associated with the queue (now that we have api to enqueue/setarg at the same time). What do you think? If you agree, I can follow up with this PR. Otherwise I am going to abandon this PR and wait for the fix in the L0 runtime.

I agree, it makes sense to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants