[WIP][Driver][SYCL] Refactor SYCL offloading behavior #19642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This patch reworks how we create offloading toolchains. Previously we would handle this separately for all the different kinds. This patch instead changes this to use the target triple and the offloading kind to determine the proper toolchain. In the old case where the user only passes `--offload-arch` we instead infer the triple from the passed arguments. This is a pretty major overhaul but currently passes all the clang tests with only minor changes to error messages.
This re-lands this change: llvm/llvm-project@a7d9365 This was a significant update to how the offloading model is initialized for creating the toolchains that are used. Here, update the SYCL offloading model that is heavily dependent on unique usage given -fsycl-targets to use this new methodology. - Update -fsycl-targets as an alias to --offload-targets - Add needed parsing to create new triples based on non-triple based targets (intel_gpu, etc)
mdtoguchi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-lands this change:
llvm/llvm-project@a7d9365
This was a significant update to how the offloading model is initialized
for creating the toolchains that are used.
Here, update the SYCL offloading model that is heavily dependent on
unique usage given -fsycl-targets to use this new methodology.
targets (intel_gpu, etc)