[SYCL] Fix multi_ptr::prefetch regression
#19013
Open
+26
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regression was introduced in intel#18839 and the error looks like: ``` /include/sycl/multi_ptr.hpp:397:5: error: no matching function for call to '__spirv_ocl_prefetch' 397 | __spirv_ocl_prefetch(reinterpret_cast<ptr_t>(get_decorated()), NumBytes); /include/sycl/multi_ptr.hpp:397:5: note: candidate function not viable: no known conversion from 'ptr_t' (aka 'const __global char *') to 'const __global signed char *' for 1st argument 397 | __spirv_ocl_prefetch(reinterpret_cast<ptr_t>(get_decorated()), NumBytes); ``` We previously switched to use `__spirv_ocl_prefetch` that is automatically defined by the compiler instead of having its forward-declaration in our headers. However, compiler-provided declaration does not define an overload for plain `char` for some reason. Changing that may trigger some unknown and unwanted side effects, so for the meantime the problem is worked around by using `unsigned char` overload instead which should be safe (from strict aliasing rules point of view).
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regression was introduced in #18839 and the error looks like:
We previously switched to use
__spirv_ocl_prefetchthat is automatically defined by the compiler instead of having its forward-declaration in our headers. However, compiler-provided declaration does not define an overload for plaincharfor some reason.Changing that may trigger some unknown and unwanted side effects, so for the meantime the problem is worked around by using
unsigned charoverload instead which should be safe (from strict aliasing rules point of view).