Skip to content

[SYCL][E2E] Mark imf test as unsupported intended for cuda/hip #19000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: sycl
Choose a base branch
from
Open

[SYCL][E2E] Mark imf test as unsupported intended for cuda/hip #19000

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sycl/test-e2e/DeviceLib/imf_bfloat16_integeral_convesions.cpp
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we move all tests with imf_ prefix to a separate imf directory.
I.e.
sycl/test-e2e/DeviceLib/imf_<test_name>.cpp ->
sycl/test-e2e/DeviceLib/imf/<test_name>.cpp

Adding sycl/test-e2e/DeviceLib/imf/lit.local.cfg with

import platform

config.unsupported_features += ['target-nvidia', 'target-amd']

should simplify the maintenance efforts.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, I'll wait for #18995 as it would conflict, and then re-work the patch as suggested.

Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
// RUN: %{run} %t2.out
//
// UNSUPPORTED: target-nvidia || target-amd
// UNSUPPORTED-INTENDED: Nvidia and AMD don't support IMF

// Windows doesn't yet have full shutdown().
// UNSUPPORTED: ze_debug && windows
Expand Down
1 change: 1 addition & 0 deletions sycl/test-e2e/DeviceLib/imf_double2bfloat16.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
// RUN: %{run} %t1.out
//
// UNSUPPORTED: target-nvidia || target-amd
// UNSUPPORTED-INTENDED: Nvidia and AMD don't support IMF

#include "imf_utils.hpp"
#include <sycl/ext/intel/math.hpp>
Expand Down
1 change: 1 addition & 0 deletions sycl/test-e2e/DeviceLib/imf_double2half.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
// RUN: %{run} %t2.out

// UNSUPPORTED: target-nvidia, target-amd
// UNSUPPORTED-INTENDED: Nvidia and AMD don't support IMF

#include "imf_utils.hpp"
#include <sycl/ext/intel/math.hpp>
Expand Down
1 change: 1 addition & 0 deletions sycl/test-e2e/DeviceLib/imf_float2bfloat16.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
// RUN: %{run} %t2.out
//
// UNSUPPORTED: target-nvidia || target-amd
// UNSUPPORTED-INTENDED: Nvidia and AMD don't support IMF

// All __imf_* bf16 functions are implemented via fp32 emulation, so we don't
// need to check whether underlying device supports bf16 or not.
Expand Down
1 change: 1 addition & 0 deletions sycl/test-e2e/DeviceLib/imf_fp16_trivial_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
// RUN: %{run} %t.out

// UNSUPPORTED: target-nvidia, target-amd
// UNSUPPORTED-INTENDED: Nvidia and AMD don't support IMF

// Windows doesn't yet have full shutdown().
// UNSUPPORTED: ze_debug && windows
Expand Down
1 change: 1 addition & 0 deletions sycl/test-e2e/DeviceLib/imf_fp32_rounding_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
// RUN: %{run} %t2.out
//
// UNSUPPORTED: target-nvidia || target-amd
// UNSUPPORTED-INTENDED: Nvidia and AMD don't support IMF

#include "imf_utils.hpp"
#include <sycl/ext/intel/math.hpp>
Expand Down
1 change: 1 addition & 0 deletions sycl/test-e2e/DeviceLib/imf_fp32_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
// RUN: %{run} %t2.out
//
// UNSUPPORTED: target-nvidia || target-amd
// UNSUPPORTED-INTENDED: Nvidia and AMD don't support IMF

// Windows doesn't yet have full shutdown().
// UNSUPPORTED: ze_debug && windows
Expand Down
1 change: 1 addition & 0 deletions sycl/test-e2e/DeviceLib/imf_fp64_rounding_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
// RUN: %{run} %t2.out
//
// UNSUPPORTED: target-nvidia || target-amd
// UNSUPPORTED-INTENDED: Nvidia and AMD don't support IMF

// Depends on SPIR-V Backend & run-time drivers version.
// XFAIL: spirv-backend && run-mode
Expand Down
1 change: 1 addition & 0 deletions sycl/test-e2e/DeviceLib/imf_fp64_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
// RUN: %{run} %t2.out
//
// UNSUPPORTED: target-nvidia || target-amd
// UNSUPPORTED-INTENDED: Nvidia and AMD don't support IMF
#include "imf_utils.hpp"
#include <sycl/ext/intel/math.hpp>

Expand Down
1 change: 1 addition & 0 deletions sycl/test-e2e/DeviceLib/imf_fp64_test2.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
// RUN: %{run} %t2.out
//
// UNSUPPORTED: target-nvidia || target-amd
// UNSUPPORTED-INTENDED: Nvidia and AMD don't support IMF

#include "imf_utils.hpp"
#include <sycl/ext/intel/math.hpp>
Expand Down
1 change: 1 addition & 0 deletions sycl/test-e2e/DeviceLib/imf_half_type_cast.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
// RUN: %{run} %t2.out

// UNSUPPORTED: target-nvidia, target-amd
// UNSUPPORTED-INTENDED: Nvidia and AMD don't support IMF

// Windows doesn't yet have full shutdown().
// UNSUPPORTED: ze_debug && windows
Expand Down
1 change: 1 addition & 0 deletions sycl/test-e2e/DeviceLib/imf_simd_emulate_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
// RUN: %{run} %t2.out
//
// UNSUPPORTED: target-nvidia || target-amd
// UNSUPPORTED-INTENDED: Nvidia and AMD don't support IMF

// UNSUPPORTED: igc-dev
// UNSUPPORTED-TRACKER: https://github.com/intel/llvm/issues/17008
Expand Down
2 changes: 1 addition & 1 deletion sycl/test/e2e_test_requirements/no-unsupported-without-info.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
// tests to match the required format and in that case you should just update
// (i.e. reduce) the number and the list below.
//
// NUMBER-OF-UNSUPPORTED-WITHOUT-INFO: 254
// NUMBER-OF-UNSUPPORTED-WITHOUT-INFO: 242
//
// List of improperly UNSUPPORTED tests.
// Remove the CHECK once the test has been properly UNSUPPORTED.
Expand Down
Loading