Skip to content
This repository was archived by the owner on Oct 23, 2023. It is now read-only.

vaDeriveImage returns operation failed #891

Open
wants to merge 1 commit into
base: apache
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion encoder/vaapiencoder_base.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,8 @@ SurfacePtr VaapiEncoderBase::createSurface(VideoFrameRawData* frame)

VAImage image;
VADisplay display = m_display->getID();
uint8_t* dest = mapSurfaceToImage(display, surface->getID(), image);
uint8_t* dest = mapSurfaceToImage(display, surface->getID(), image,
frame->width, frame->height, fourcc);
if (!dest) {
ERROR("map image failed");
return nil;
Expand Down
22 changes: 18 additions & 4 deletions vaapi/VaapiUtils.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,26 @@

namespace YamiMediaCodec {

uint8_t* mapSurfaceToImage(VADisplay display, intptr_t surface, VAImage& image)
uint8_t* mapSurfaceToImage(VADisplay display, intptr_t surface, VAImage& image,
uint32_t width, uint32_t height, uint32_t fourcc)
{
uint8_t* p = NULL;
VAStatus status = vaDeriveImage(display, (VASurfaceID)surface, &image);
if (!checkVaapiStatus(status, "vaDeriveImage"))
return NULL;
VAStatus status;
if (width == 0 && height == 0 && fourcc == 0) {
status = vaDeriveImage(display, (VASurfaceID)surface, &image);
if (!checkVaapiStatus(status, "vaDeriveImage"))
return NULL;
} else {
VAImageFormat format;
format.fourcc = fourcc;
status = vaCreateImage(display, &format, width, height, &image);
if (!checkVaapiStatus(status, "vaCreateImage"))
return NULL;
status = vaPutImage(display, (VASurfaceID)surface, image.image_id, 0, 0,
width, height, 0, 0, width, height);
if (!checkVaapiStatus(status, "vaPutImage"))
return NULL;
}
status = vaMapBuffer(display, image.buf, (void**)&p);
if (!checkVaapiStatus(status, "vaMapBuffer")) {
checkVaapiStatus(vaDestroyImage(display, image.image_id), "vaDestroyImage");
Expand Down
3 changes: 2 additions & 1 deletion vaapi/VaapiUtils.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@

namespace YamiMediaCodec {

uint8_t* mapSurfaceToImage(VADisplay display, intptr_t surface, VAImage& image);
uint8_t* mapSurfaceToImage(VADisplay display, intptr_t surface, VAImage& image,
uint32_t width = 0, uint32_t height = 0, uint32_t fourcc = 0);

void unmapImage(VADisplay display, const VAImage& image);

Expand Down