use pytest-skip plugin for selection in the test script #5502
+20
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes --text-expr argument and replaces it with --select <name> Refactors --pdb pytest call into pytest-utils.sh Signed-off-by: Sławomir Błauciak <[email protected]>
vlad-penkin
requested changes
Nov 19, 2025
| ) | ||
| fi | ||
|
|
||
| if [[ $TRITON_TEST_DEBUG_FAIL = true ]]; then |
Contributor
There was a problem hiding this comment.
Why do we need this option? In my opinion our developers usually debug individual test variant and call pytest directly.
Contributor
Author
There was a problem hiding this comment.
It was added in the previous PR
| --test-expr) | ||
| TEST_FILTER_EXPRESSION="$2" | ||
| --select) | ||
| TRITON_TEST_SELECT="$2" |
Contributor
There was a problem hiding this comment.
Will this option work in conjunction with the skiplist?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes --text-expr argument and replaces it with --select
Refactors --pdb pytest call into pytest-utils.sh