Add Grouped GEMM for Mixed Dtype #457
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t4c1
reviewed
Jul 7, 2025
There was a problem hiding this comment.
Can you rename this example to list the types instead of "mixed_dtype"?
| using ret_type = cute::conditional_t<sizeof_bits_v<ElementZero> >= 8, ElementZero, int8_t>; | ||
| ret_type a = [&]() { | ||
| if constexpr (sizeof_bits_v<QuantizedElement> >= 8) { | ||
| return (ret_type)(src_tensor(n, k, l)); |
There was a problem hiding this comment.
Suggested change
| return (ret_type)(src_tensor(n, k, l)); | |
| return static_cast<ret_type>(src_tensor(n, k, l)); |
And a few more examples of this below.
| Tensor<EngineScales, LayoutScales>& tCrS_input, | ||
| Tensor<EngineZeros, LayoutZeros> tCrZ_input | ||
| ) { | ||
| // TODO: add assert here because such cases not support for int4 now |
There was a problem hiding this comment.
Suggested change
| // TODO: add assert here because such cases not support for int4 now | |
| // TODO (Codeplay): add assert here because int4 is not currently supported |
…tlass-fork into mixed_group_gemm
…tlass-fork into mixed_group_gemm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Grouped GEMM support for mixed precision GEMM.