Skip to content

Conversation

@TianyouLi
Copy link
Contributor

Problem

When build as 'make dist', it will report errors like below:

   internal/script/script.go:21:3: invalid go:embed: build system did not supply embed configuration (compile)
   internal/script/script.go:21:12: pattern resources: cannot embed directory resources: contains no embeddable files (compile)
   make: *** [Makefile:90: check_static] Error 1

Proposed Solution

Check if the resources/x64 directory is empty, if yes, just touch a empty file to workaround the go compilation error

@TianyouLi TianyouLi requested a review from harp-intel as a code owner December 3, 2024 07:21
@harp-intel
Copy link
Contributor

Prefer that build fails when binaries are not present. The binaries are required for perfspect to operate properly.

@harp-intel harp-intel closed this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants