disable serial logs by default for release binary #607
Conversation
Signed-off-by: Gudaram, Meghana <[email protected]>
| futures-util = { version = "0.3.17", default-features = false } | ||
| lazy_static = { version = "1.0", features = ["spin_no_std"] } | ||
| log = { version = "0.4.13" } | ||
| log = { version = "0.4.13", features = ["release_max_level_off"] } |
There was a problem hiding this comment.
Will this impact entry log later on when the that uses the td_logger crate later on?
There was a problem hiding this comment.
At this moment I am not sure, it would depend on how we implement it (how we create the switch to decide serial vs memory). if we want to, we can honor it for entrylog scenario i.e. serial logs disabled.
There was a problem hiding this comment.
Maybe we should first clarify the expected behavior on serial log and memory log. My personal understanding is:
| Memory Log | Serial Log | |
|---|---|---|
| Controlled by GHCI at runtime | Yes | No |
| Controlled by debug/release build | No | Yes |
| Level | OFF/ERROR/WARN/INFO/DEBUG/TRACE | OFF(release)/ON(debug) |
Thought?
There was a problem hiding this comment.
this looks good to me, release_max_level_off/max_level_debug is something queried on log RUST crate applicable to only serial log release/debug respectively. Similarly through ghci we have max_level requested by VMM applicable to entrylog/memory logs.
3 participants
No description provided.