Skip to content

Refactor code in main.rs #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Refactor code in main.rs #597

wants to merge 1 commit into from

Conversation

@agokarn
Copy link
Contributor

@agokarn agokarn commented Nov 20, 2025 •
edited
Loading

The pull request refactors code in Main.rs. Split do_measurements() and get_policy_and_measure into two variants – for policy_v2 and existing v1 policy.

@agokarn agokarn requested a review from jyao1 as a code owner November 20, 2025 00:51
@agokarn agokarn marked this pull request as draft November 20, 2025 00:51
@agokarn agokarn force-pushed the user/arthig/add-get-quote branch 3 times, most recently from 90e0fb9 to ca07557 Compare November 20, 2025 04:29
@agokarn agokarn marked this pull request as ready for review November 20, 2025 04:29
@jyao1
Copy link
Contributor

jyao1 commented Nov 21, 2025 •
edited
Loading

Please split the PR to 2 different PRs:

  1. Modify Makefile for Azure
  2. refactor code in main.rs

They are totally different tasks to resolve different problem.

I might approve 1) Azure specific change quickly.
But I need deep understanding on 2), what problem you want to resolve by refactoring.

Grand rule: each PR resolves and only resolves one specific problem.

@agokarn
Modify Makefile for Azure, refactor code in main.rs
d651285 
Revert changes to do_measurements

Refactor

	modified:   sh_script/Azure/Makefile
	modified:   sh_script/fuzzing.sh
	modified:   src/migtd/src/bin/migtd/main.rs

Add formatting.

	modified:   sh_script/Azure/Makefile
	modified:   sh_script/fuzzing.sh
	modified:   src/migtd/src/bin/migtd/main.rs

Increase timeout for build_AzCVMEmu_policy_and_test.sh to complete.

	modified:   .github/workflows/integration-emu.yml
	modified:   sh_script/Azure/Makefile
	modified:   sh_script/fuzzing.sh
	modified:   src/migtd/src/bin/migtd/main.rs

Remove non Makefile changes.
@agokarn agokarn force-pushed the user/arthig/add-get-quote branch from ca07557 to d651285 Compare November 21, 2025 03:02
@agokarn agokarn changed the title Modify Makefile for Azure, refactor code in main.rs Refactor code in main.rs Nov 21, 2025
@agokarn
Copy link
Contributor Author

agokarn commented Nov 21, 2025

Please split the PR to 2 different PRs:

  1. Modify Makefile for Azure
  2. refactor code in main.rs

They are totally different tasks to resolve different problem.

I might approve 1) Azure specific change quickly. But I need deep understanding on 2), what problem you want to resolve by refactoring.

Grand rule: each PR resolves and only resolves one specific problem.

@agokarn agokarn closed this Nov 21, 2025
@agokarn agokarn reopened this Nov 21, 2025
@jyao1
Copy link
Contributor

jyao1 commented Nov 21, 2025

Why we need change sh_script/fuzzing.sh?

The commit message is not right. It still has the old content.

@agokarn
Copy link
Contributor Author

agokarn commented Nov 21, 2025

The pull request refactors code in Main.rs. Split do_measurements() and get_policy_and_measure into two variants – for policy_v2 and existing v1 policy.

Why we need change sh_script/fuzzing.sh?

The commit message is not right. It still has the old content.

I can close this and start a new PR>

@agokarn agokarn marked this pull request as draft November 21, 2025 04:28
@agokarn agokarn closed this Nov 21, 2025
@agokarn agokarn deleted the user/arthig/add-get-quote branch November 21, 2025 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jyao1 jyao1 Awaiting requested review from jyao1 jyao1 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@agokarn @jyao1