-
Notifications
You must be signed in to change notification settings - Fork 905
chore(actions): Add doc how to verify GH attestations with GitHub cli and verify release artifacts with Cosign #2846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
10dbe42 to
cc98a12
Compare
Signed-off-by: Viacheslav Kudinov <[email protected]>
cc98a12 to
4d2ad53
Compare
|
Any known thing why we may regret by adding attestation? Just loudly thinking if anything we need to consider |
Signed-off-by: Viacheslav Kudinov <[email protected]>
|
@nickfloyd @stevehipwell I've updated PR to resolve conflicts after workflows were updated. Please, feel free to suggest any updates. |
stevehipwell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to add the cosign equivalents of the gh commands? We also ought to provide the command to verify the SHA256SUMS file signature.
c992315 to
56c8a2e
Compare
56c8a2e to
17126dc
Compare
17126dc to
00de37c
Compare
|
@stevehipwell i've updated doc. Please, let me know if something else was expected or i've missed. |
stevehipwell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added some comments, note that you can also verify the attestations with cosign.
Co-authored-by: Steve Hipwell <[email protected]>
Co-authored-by: Steve Hipwell <[email protected]>
Co-authored-by: Steve Hipwell <[email protected]>
Resolves #NaN
Before the change?
After the change?
https://docs.github.com/en/actions/how-tos/secure-your-work/use-artifact-attestations/use-artifact-attestations
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!