-
Notifications
You must be signed in to change notification settings - Fork 905
docs: Add missing link to schema for merge_queue repository rule
#2581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
docs: Add missing link to schema for merge_queue repository rule
#2581
Conversation
Replace copy-pasted description.
|
Hello! Can this please be reviewed (& hopefully merged) by a maintainer? Thanks! (cc: @kfcampbell @nickfloyd) |
|
Hey @usmonster 👋 Thank you for your contribution! I'm in the process of overhauling our docs foundations in #2987 Would you be willing to rebase/recreate your changes against that branch? |
|
Hi @diega, thanks for the heads-up. I could rebase, but since mine is a tiny change, would it be simpler for this to be merged down first? What do you think? |
|
It's not going to be simpler, because I'm ENTIRELY overhauling the docs even removing the current files 😬 But, I'll take it. It's my "fault" for starting this work pre-emptively of the v7 release 😬 |
stevehipwell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolves #2579
Before the change?
merge_queueruleset docs missing link to rule schema.merge_queue.max_entries_to_mergerule description is copy-pasted frommerge_queue.max_entries_to_build.After the change?
merge_queue.max_entries_to_mergerule description is correct.Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!