feat: add data sources for listing GitHub App installations in an organization #2573
Conversation
…tion This commit introduces a new data source, 'github_organization_app_installations', to enable listing all installed GitHub Apps within an organization. References: - API Documentation: https://docs.github.com/en/rest/orgs/orgs?apiVersion=2022-11-28#list-app-installations-for-an-organization - Related Issue: integrations#2570 Signed-off-by: atilsensalduz <[email protected]>
atilsensalduz
changed the title
…tion This commit introduces a new data source, 'github_organization_app_installations', to enable listing all installed GitHub Apps within an organization. References: - API Documentation: https://docs.github.com/en/rest/orgs/orgs?apiVersion=2022-11-28#list-app-installations-for-an-organization - Related Issue: integrations#2570 Signed-off-by: atilsensalduz <[email protected]>
|
👋 Hey Friends, this pull request has been automatically marked as |
deiga
left a comment
deiga
left a comment
There was a problem hiding this comment.
Hey 👋
Thank you for your contribution!
I've requested a few changes to make this fit into the provider even better :)
| return &schema.Resource{ | ||
| Read: dataSourceGithubOrganizationAppInstallationsRead, | ||
|
|
||
| Schema: map[string]*schema.Schema{ | ||
| "installations": { | ||
| Type: schema.TypeList, | ||
| Computed: true, | ||
| Elem: &schema.Resource{ | ||
| Schema: map[string]*schema.Schema{ | ||
| "id": { | ||
| Type: schema.TypeInt, | ||
| Computed: true, | ||
| }, | ||
| "slug": { | ||
| Type: schema.TypeString, | ||
| Computed: true, | ||
| }, | ||
| "app_id": { | ||
| Type: schema.TypeInt, | ||
| Computed: true, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| } | ||
| } |
There was a problem hiding this comment.
issue: Could you please add Description fields to the Schema and all fields?
|
|
||
| func dataSourceGithubOrganizationAppInstallations() *schema.Resource { | ||
| return &schema.Resource{ | ||
| Read: dataSourceGithubOrganizationAppInstallationsRead, |
There was a problem hiding this comment.
suggestion: Could you refactor this to use ReadContext?
| import ( | ||
| "context" | ||
|
|
||
| "github.com/google/go-github/v66/github" |
There was a problem hiding this comment.
suggestion: I doubt we'll be able to land this before #2602
Maybe you could even rebase on top of that branch?
| "github.com/google/go-github/v66/github" | |
| "github.com/google/go-github/v77/github" |
| "app_id": { | ||
| Type: schema.TypeInt, | ||
| Computed: true, | ||
| }, |
There was a problem hiding this comment.
suggestion: Could you add the following fields to this:
- repository_selection
- permissions
- events
- html_url
- client_id
- target_id
- target_type
- suspended
github-project-automation
bot
moved this from 👀 In review
to 🏗 In progress
in 🧰 Octokit Active
2 participants
This PR introduces a new data source, github_app_installations, to enable listing all installed GitHub Apps within an organization. This addition enhances integration with existing resources such as github_app_installation_repository, providing better automation and management capabilities for GitHub App permissions.
What's New?
New Data Source: github_app_installations
Allows fetching all installed GitHub Apps in an organization:
data "github_organization_app_installations" "all_apps" {}Example Use Case:
This data source can be integrated with the github_app_installation_repository resource to manage app permissions on specific repositories:
API Reference: https://docs.github.com/en/rest/orgs/orgs?apiVersion=2022-11-28#list-app-installations-for-an-organization
Related Issue: #2570