Add caveat about what greasing doesn't do #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And why it's good enough for many purposes. Signed-off-by: Dave Thaler <[email protected]>
tfpauly
approved these changes
Jul 21, 2025
|
A very good point! |
LPardue
reviewed
Jul 21, 2025
| grease values are correctly treated as ignored or errors. As such, it is still possible | ||
| that ossification can still occur where other reserved values are not allocatable | ||
| without causing problems in practice. The goal is simply to increase the chances | ||
| of correct implementation. |
There was a problem hiding this comment.
I like the point.
I might change the language a little bit though. An alternative phrasing could be something g like
Greasing is limited to exercising grease values. It cannot exercise other values that are reserved for future use or later allocation by protocol extensions. As such, ossification remains a possibility, with the risk of non-grease values causing an issue in practice. The goal of greasing is to reduce this possibilty but it cannot eliminate it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And why it's good enough for many purposes.