Allow control of HttpMessageHandler lifetime. #232
Open
davidathompson wants to merge 1 commit intointacct:masterfrom
Open
Allow control of HttpMessageHandler lifetime. #232davidathompson wants to merge 1 commit intointacct:masterfrom
davidathompson wants to merge 1 commit intointacct:masterfrom
Conversation
…erty called MockHandler to ensure any direct use of the name "MockHandler" will still work. Because MockHandler ultimately derives from HttpMessageHandler, all unit tests can now populate this and still work as they have been. This change allows a library user to control the life cycle of HttpMessageHandler, while still hooking into the logging provided.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The library currently creates a new HttpMessageHandler for each request. If you open up resource monitor, or use netstat you will start to see hundreds (or thousands) of open tcp connections.
Background for this:
https://www.aspnetmonsters.com/2016/08/2016-08-27-httpclientwrong/
https://docs.microsoft.com/en-us/dotnet/api/system.net.http.httpclient?redirectedfrom=MSDN&view=net-6.0#Remarks
This pull request changes the datatype and name in the ClientConfig to HttpMessageHandler. This allows a user who wishes to control lifetime of the handler to supply their own instance.
Unit tests were updated to use the new generic name, with an obsolete property which points back to it to avoid breaking existing users.