Skip to content

feat: custom worker classes #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Apr 24, 2025
Merged

feat: custom worker classes #4

merged 13 commits into from
Apr 24, 2025

Conversation

@instrumentl707
Copy link
Collaborator

@instrumentl707 instrumentl707 commented Apr 23, 2025 •
edited
Loading

Add support to provide custom ::Sidekiq classes for the Worker.

See https://github.com/instrumentl/instrumentl/pull/13695 for example use case.

@instrumentl707 instrumentl707 force-pushed the feat/custom-worker-classes branch from 33c432d to a78b93e Compare April 23, 2025 16:02
@instrumentl707 instrumentl707 force-pushed the feat/custom-worker-classes branch from a78b93e to 37aa16f Compare April 23, 2025 16:26
instrumentl707
instrumentl707 commented Apr 23, 2025
View reviewed changes
@instrumentl707 instrumentl707 self-assigned this Apr 23, 2025
@instrumentl707 instrumentl707 added the enhancement New feature or request label Apr 23, 2025
@instrumentl707 instrumentl707 marked this pull request as ready for review April 23, 2025 16:40
@instrumentl707 instrumentl707 marked this pull request as draft April 23, 2025 16:49
@instrumentl707 instrumentl707 force-pushed the feat/custom-worker-classes branch from 93eb92f to 61843e1 Compare April 23, 2025 16:52
@instrumentl707 instrumentl707 marked this pull request as ready for review April 23, 2025 20:05
@instrumentl707 instrumentl707 force-pushed the feat/custom-worker-classes branch from 61843e1 to 6446a2a Compare April 23, 2025 21:44
@instrumentl707
Copy link
Collaborator Author

instrumentl707 commented Apr 23, 2025

I don't think fork ever passed CI.

Roguelazer
Roguelazer reviewed Apr 24, 2025
View reviewed changes
Copy link

@Roguelazer Roguelazer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests?

senthil-instrumentl
senthil-instrumentl reviewed Apr 24, 2025
View reviewed changes
Copy link

@senthil-instrumentl senthil-instrumentl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@instrumentl707
Copy link
Collaborator Author

instrumentl707 commented Apr 24, 2025

tests?

I can add tests, but it would require fixing the existing tests that never passed to begin with.

@instrumentl707 instrumentl707 force-pushed the feat/custom-worker-classes branch from 36bf629 to 27a5905 Compare April 24, 2025 14:47
@instrumentl707 instrumentl707 force-pushed the feat/custom-worker-classes branch from 27a5905 to 26689a5 Compare April 24, 2025 14:48
@instrumentl707 instrumentl707 merged commit 80a98de into master Apr 24, 2025
4 checks passed
@instrumentl707 instrumentl707 deleted the feat/custom-worker-classes branch April 24, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexneigher alexneigher Awaiting requested review from alexneigher

@Opus1no3 Opus1no3 Awaiting requested review from Opus1no3

@senthil-instrumentl senthil-instrumentl Awaiting requested review from senthil-instrumentl

@Roguelazer Roguelazer Awaiting requested review from Roguelazer

Assignees

@instrumentl707 instrumentl707

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@instrumentl707 @Roguelazer @senthil-instrumentl @sam-albon-li