Update AWS wrapper to not hide proper exceptions #770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
|
@GSVarsha I can add a test case tomorrow morning EST. If you have time before then please feel free to add one |
GSVarsha
force-pushed
the
main
branch
2 times, most recently
from
5fad66c to
2c84c59
Compare
|
@GSVarsha thank you for adding the test! Is there anything else that needs to happen before this can be merged+released? |
|
@HonakerM please rebase the branch on top of the upstream repo's main. I will get a review from one other member from the team too since I'm a committer as well. |
Signed-off-by: Michael Honaker <[email protected]>
Signed-off-by: Michael Honaker <[email protected]>
…d_fileobj() Signed-off-by: Varsha GS <[email protected]>
|
@GSVarsha Rebased! Please let me know if there is anything else I can do |
Signed-off-by: Varsha GS <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the errors described in #769.
Not only does it update the code to properly fetch the bucket name for upload_fileobj it also ensures we don't hide proper exceptions from the client