Feat: paper reproduction - #240
Draft
JemmaLDaniel wants to merge 24 commits into
Draft
Conversation
… tool benchmarking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a reviewer-facing path to regenerate Winnow paper figures and tables from public pins.
paper_scripts/analysis and plot helpers, documented inpaper_scripts/README.md.Makefile.paperwithpaper-plot-*(deposit replot) vspaper-recompute-*(predict / train / other benchmarks and analyses), plus laptop vs heavy umbrellas.paperdependency group (not a published extra) pins Glissade at a git SHA. The lockfile has also been updated.Makefileclean helpers and.gitignoreentries forpaper_data/,paper_results/,paper_plots/.compute_features.yamltraining_matrix_output_path: null, InstaNovo spelling indocs/cli.md.The published
winnowAPI is unchanged. Reproduction logic is not imported frompaper_scripts/into the package.Test plan
make -f Makefile.paper paper-sync-group-paperthenmake -f Makefile.paper helpmake -f Makefile.paper paper-setup(or selective downloads) thenpaper-check-artefactsmake -f Makefile.paper paper-plot-lightagainst deposited artefactsmake -f Makefile.paper paper-recompute-laptop(needs Koina connection)uv syncwithout--group paperstill installs the published package onlyNote for reviewers
The logic in these scripts must be merged unchanged, but they should all be readable without too much work.