Skip to content

Fix PointNovo loader initialization on Python 3.10 #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BioGeek merged 2 commits into from
Aug 18, 2026
Merged

Fix PointNovo loader initialization on Python 3.10 #236

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9813aa6
Fix PointNovo loader initialization on Python 3.10
BioGeek Aug 12, 2026
6db3c15
Modernize PointNovo type hints
BioGeek Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions winnow/datasets/data_loaders/pointnovo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
from __future__ import annotations

from pathlib import Path
from typing import Any, Optional
from typing import Any

from winnow.datasets.calibration_dataset import CalibrationDataset
from winnow.datasets.interfaces import DatasetLoader
Expand All @@ -15,8 +15,22 @@ class PointNovoDatasetLoader(DatasetLoader):
Note: This loader is not yet implemented.
"""

def __init__(
self,
residue_masses: dict[str, float],
residue_remapping: dict[str, str] | None = None,
isotope_error_range: tuple[int, int] = (0, 1),
) -> None:
"""Initialise the loader with the common dataset-loader options.

The loader does not use these options until PointNovo support is implemented,
but defining the initializer makes this a concrete implementation of the
``DatasetLoader`` protocol on Python 3.10.
"""
del residue_masses, residue_remapping, isotope_error_range

def load(
self, *, data_path: Path, predictions_path: Optional[Path] = None, **kwargs: Any
self, *, data_path: Path, predictions_path: Path | None = None, **kwargs: Any
) -> CalibrationDataset:
"""Load a calibration dataset from PointNovo predictions."""
raise NotImplementedError("PointNovoDatasetLoader is not yet implemented")
Loading