feat: unify Midnight wallet onboarding flow [LW-13693] #2103
+410
−187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Allure Report
processReports: ❌ test report for 3f179f81
|
przemyslaw-wlodek
force-pushed
the
feat/LW-13693-midnight-onboarding-v1
branch
4 times, most recently
from
abecbef to
9ca9d2d
Compare
przemyslaw-wlodek
force-pushed
the
feat/LW-13693-midnight-onboarding-v1
branch
2 times, most recently
from
abfa24b to
57cf49a
Compare
przemyslaw-wlodek
force-pushed
the
feat/LW-13693-midnight-onboarding-v1
branch
from
57cf49a to
a96354e
Compare
vetalcore
reviewed
Dec 11, 2025
Comment on lines
32
to
36
| const keyMaterialBytes = await Wallet.KeyManagement.emip3decrypt( | ||
| new Uint8Array(Buffer.from(walletToReuse.encryptedRecoveryPhrase, 'hex')), | ||
| new Uint8Array(Buffer.from(password)) | ||
| ); | ||
| mnemonic = Buffer.from(keyMaterialBytes).toString('utf8').split(' '); |
Contributor
There was a problem hiding this comment.
could have created some getMnemonicForWallet somewhere in the lmp utils? :)
Contributor
Author
There was a problem hiding this comment.
Yep! Thanks. I am currently applying some of the improvements, like this one. :)
Contributor
There was a problem hiding this comment.
Btw, this is the same as what is happening here. Maybe you can reuse
greatertomi
reviewed
Dec 11, 2025
| import { Portal } from '@views/browser/features/wallet-setup/components/Portal'; | ||
| import { APP_MODE, lmpModeStorage } from '@src/utils/lmp'; | ||
|
|
||
| const CAME_FROM_LMP_KEY = 'lace-came-from-lmp'; |
Contributor
There was a problem hiding this comment.
We should centralize this key and not repeat it
| wallet !== null && typeof wallet === 'object' && 'walletName' in wallet; | ||
|
|
||
| const getWalletDisplayName = (wallet: unknown): string | undefined => | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any |
Contributor
There was a problem hiding this comment.
Use a more exact type
Suggested change
| // eslint-disable-next-line @typescript-eslint/no-explicit-any |
Comment on lines
11
to
15
| type MidnightWallet = { walletId: string; walletName: string; encryptedRecoveryPhrase?: string }; | ||
|
|
||
| const isMidnightWallet = (wallet: unknown): wallet is MidnightWallet => | ||
| wallet !== null && typeof wallet === 'object' && 'walletName' in wallet; |
Contributor
There was a problem hiding this comment.
Maybe something like this? We don't need to create this MidnightWallet type and LmpBundleWallet has a blockchain property which is a more deterministic way to check this
Suggested change
| type MidnightWallet = { walletId: string; walletName: string; encryptedRecoveryPhrase?: string }; | |
| const isMidnightWallet = (wallet: unknown): wallet is MidnightWallet => | |
| wallet !== null && typeof wallet === 'object' && 'walletName' in wallet; | |
| const isMidnightWallet = (wallet: unknown): wallet is LmpBundleWallet => | |
| wallet !== null && typeof wallet === 'object' && (wallet as LmpBundleWallet).blockchain === 'Midnight'; |
Comment on lines
32
to
36
| const keyMaterialBytes = await Wallet.KeyManagement.emip3decrypt( | ||
| new Uint8Array(Buffer.from(walletToReuse.encryptedRecoveryPhrase, 'hex')), | ||
| new Uint8Array(Buffer.from(password)) | ||
| ); | ||
| mnemonic = Buffer.from(keyMaterialBytes).toString('utf8').split(' '); |
Contributor
There was a problem hiding this comment.
Btw, this is the same as what is happening here. Maybe you can reuse
|
|
||
| export type ReusableWallet = | ||
| | AnyWallet<Wallet.WalletMetadata, Wallet.AccountMetadata> | ||
| | { walletId: string; walletName: string; encryptedRecoveryPhrase?: string }; |
Contributor
There was a problem hiding this comment.
Suggested change
| | { walletId: string; walletName: string; encryptedRecoveryPhrase?: string }; | |
| | LmpBundleWallet; |
przemyslaw-wlodek
force-pushed
the
feat/LW-13693-midnight-onboarding-v1
branch
4 times, most recently
from
f328133 to
b3a2493
Compare
- Add Midnight to "Select Blockchain" screen (create/restore wallet) - Remove separate AddNewMidnightWalletLink from dropdown menu - Add useLMP hook with startMidnightCreate/Restore methods
przemyslaw-wlodek
force-pushed
the
feat/LW-13693-midnight-onboarding-v1
branch
from
b3a2493 to
4bd853f
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Please see the commits.