Skip to content

fs-api: tighten the package bound on Win32 #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025
Merged

Conversation

geo2a
Copy link
Contributor

@geo2a geo2a commented Jun 11, 2025

No description provided.

@geo2a geo2a requested a review from a team as a code owner June 11, 2025 13:06
@jorisdral
Copy link
Contributor

Personally, I've never tried to tighten these bounds because I don't have a Windows machine that I could test different bounds on 😛 In lsm-tree, we also support only 2.14, so I see no problems here

BTW, there are some CI jobs that are not listed are required. I think it's the jobs that were added back in #103

@geo2a
Copy link
Contributor Author

geo2a commented Jun 12, 2025

We've discovered that we are missing the upper bound when @jasagredo tried to upload a package candidate to Hackage. I've just copy-pasted the bounds from lsm-tree 🧠

BTW, there are some CI jobs that are not listed are required.

I've indeed forgotten to make some of them required again, thanks @jorisdral!

@jorisdral
Copy link
Contributor

We've discovered that we are missing the upper bound when @jasagredo tried to upload a package candidate to Hackage. I've just copy-pasted the bounds from lsm-tree 🧠

Ah, yes, I think Hackage only recently started complaining about missing upper bounds for new package uploads

@geo2a geo2a added this pull request to the merge queue Jun 12, 2025
Merged via the queue into main with commit ee0b75b Jun 12, 2025
22 checks passed
@geo2a geo2a deleted the geo2a/win32-package-bound branch June 12, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants