Skip to content

Conversation

@madmuffin1
Copy link
Contributor

No description provided.

@madmuffin1
Copy link
Contributor Author

I still need to verify it to work, the bank I have access to right now do not support pain.001.001.09, but I asked our accountant to try with an account that supposedly works with it already.

@madmuffin1
Copy link
Contributor Author

@pblanchardie from my side this is good to go. We were able to execute a Instant Payment today.

I also included a change in V09 that requires the PmtInf > DbtrAgt > FinInstnId to be filled, which was not the case in V01.

Comment on lines +267 to +268
}, () -> {
throw new IllegalArgumentException("BIC must be provided for debtor account");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the XSD, there is no difference between V03 and V09:
Yes FinInstnId is mandatory, but the XSD allows it to be empty.
In other terms, it does not mandate BICFI, nor other child elements:

  • ClrSysMmbId
  • LEI
  • Nm
  • PstlAdr
  • Othr

So I'm not comfortable with throwing IllegalArgumentException when an apparently optional field is missing.

Or did I miss something?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@madmuffin1 can I have your feedback on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants