Repository navigation
Conversation
When scrobbling asks first (Ask every Huddle or Ask for every track), a new "Always scrobble songs I add" checkbox on the You tab scrobbles songs the listener queued themselves without asking. Songs others or autoplay added still ask, turning scrobbling off for a session still wins, and with the checkbox off nothing changes. Amp-Thread-ID: https://ampcode.com/threads/T-01a1b441-6095-712e-a011-33d4f7e1eba0 Co-authored-by: Ingo <me@ingo.au>
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 58 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggested in Slack: with an ask-before-scrobbling mode on, songs you queued yourself still asked for confirmation.
What changes
A new checkbox on the You tab of Settings, under the scrobbling default: Songs you add — Always scrobble songs I add. It's saved per user (
user_scrobbling.scrobble_own_tracks, default off).When it's on and the listener's mode is Ask every Huddle or Ask for every track:
With the checkbox off, behaviour is exactly as before.
Testing
bun run checkpasses.scrobbling.test.tscovers: own song with the checkbox off (asked, not scrobbled); own, others' and autoplay songs with it on in Ask for every track mode; and Ask every Huddle mode before and after turning the session off. The test fails when the setting is ignored.coordinator.test.tsand the field-order test insettings-schema.test.tsnow include the checkbox.bun test: 873 pass, 6 fail. The same 6 tests (3 intracks.test.ts, 3 inchime-link.test.ts) also fail on unchangedmainin this environment.