Skip to content

Find the huddle you're in from Slack's calls on Slick - #212

Merged
ingoau merged 1 commit into
mainfrom
t3/slick-find-huddle
Nov 5, 2026
Merged

ingoau merged 1 commit into
mainfrom
t3/slick-find-huddle

Conversation

@ingoau

@ingoau ingoau commented Nov 5, 2026 •

Copy link
Copy Markdown
Owner

Start HuddleFM on Slick logged `Can't start HuddleFM: not in a huddle, or none is chosen` while in a huddle. The plugin found the huddle with Slack's `getActiveHuddleChannelId` selector, by its `meta.name`, and current Slack builds don't name their selectors, so it never matched.

  • `clients/slick/HuddleFM.tsx`: reads `allCalls.byId` for the latest huddle that hasn't ended with you in `activeParticipants`, falling back to the named selector. (`activeCall` doesn't say which call you're in.)
  • `clients/core/mod.tsx`: the log says whether the huddle or the chosen HuddleFM is missing.
  • `clients/slick/README.md`: describes the new lookup.

Checked against a live Slack state dump; the client tests pass. Not yet run as a built plugin.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Starting HuddleFM now selects the most recently started active huddle that includes you. If no matching huddle is found, it falls back to the existing channel lookup.
    • You’ll receive a distinct message when no HuddleFM user is selected versus when no active huddle channel is available. In either case, no Slack invitation is sent.
  • Documentation
    • Updated the Slick guide to describe huddle selection and fallback behavior.

Slack builds without selector names left Start HuddleFM unable to find the
huddle, so it reads allCalls for the unended huddle you're active in, and
falls back to the named selector. The log now says which part is missing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Slick now finds the current member’s active huddle from Slack call state, with a selector fallback. The invite flow reports separately when no bot is chosen and when no huddle channel is available.

Changes: HuddleFM Invite Flow

Layer / File(s) Summary
Resolve the active huddle channel
clients/slick/HuddleFM.tsx, clients/slick/README.md
Slick checks active calls for a non-ended huddle that includes the current member. It selects the matching call with the latest start date and falls back to getActiveHuddleChannelId. The README describes this lookup.
Report missing invite inputs
clients/core/mod.tsx
The invite flow reports separately when no bot is chosen and when no huddle channel is found.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Possibly related PRs

  • ingoau/huddlefm#191: Adds the shared HuddleFM mod and invitation flow that this change updates.

Suggested reviewers: claude

Merge Risk: Minimal · up to 66f1b

No confirmed issue currently prevents merging the huddle lookup change after normal checks.

Pre-merge checks: Passed 5

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: locating the current huddle from Slack's calls state in Slick.
Docstring Coverage Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 2 files. (1 skipped: 1 unsupported.)

Finishing Touches

Generate docstrings

  • Commit to this branch
  • Create a new PR
Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0380d494-7526-46d1-bb3a-5ef06fad3768
Commits

Reviewing files that changed from the base of the PR and between a67d808 and 66f1b27.

Files selected for processing: 3

  • clients/core/mod.tsx
  • clients/slick/HuddleFM.tsx
  • clients/slick/README.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@ingoau
ingoau merged commit 6842f77 into main Nov 5, 2026
7 checks passed
@ingoau
ingoau deleted the t3/slick-find-huddle branch November 5, 2026 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant