Repository navigation
Leave a hidden tile out of the huddle's layout too - #198
Merged
Merged
Conversation
Slack's tile views count, size and page tiles from the huddle's peers before the grid draws them, so filtering the grid left a gap and an extra page. Render those views over state where the bot hasn't connected. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 56 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…te answer Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Taut plugin's internals moved to clients/core in #197, so the tile views' state patch moves there too, behind an optional Host.StateView that Taut provides. Slick has no StateView, so it keeps hiding the tile in the grid alone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Hide HuddleFM's tile on, the bot's tile was gone, but the huddle still left room for it: an empty slot, and an extra page in the compact window.
The grid only draws a page. Slack's views above it (
HuddleCompactVideoPane,HuddleCompactAudioPane,HuddleGridContainer,GridPicker, and the mini, minimized-self and strip layouts) count, size and page tiles from the peers themselves, through one hook. Filtering the grid's props came too late.Now the plugin renders those views with Taut's
StateView, over state where:peers.byIdhave noisConnected. Slack lists only connected peers, including the active speakers and the gallery's page count.pendingUsers. Otherwise the hook shows an invited peer that isn't connected as joining.lastInviteStatusByUser, which would otherwise show it as declined.All the views share one patch, so Slack's selectors, which remember only their last input, aren't recomputed on every action.
Screen shares come from every peer, so the bot's video-mode share stays. The participants menu isn't wrapped, so the bot is still listed there. The old grid filter stays as a fallback for any view Slack adds.
Checked against Slack's current web client bundle. Type-check, Biome and the plugin build pass against the pinned Taut. It hasn't been tried in a live huddle yet.
🤖 Generated with Claude Code