Skip to content

Introduced protections against predictable RNG abuse #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pixeebot wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Introduced protections against predictable RNG abuse #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions core/src/main/java/de/javakaffee/web/msm/NodeIdService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
*/
package de.javakaffee.web.msm;

import java.security.SecureRandom;
import java.util.ArrayList;
import java.util.Collection;
import java.util.List;
Expand All @@ -39,7 +40,7 @@ public class NodeIdService {
@SuppressWarnings( "unused" )
private static final Log LOG = LogFactory.getLog( NodeIdService.class );

private final Random _random = new Random();
private final Random _random = new SecureRandom();

/*
* Manager.remove(session) may be called with sessionIds that already failed before (probably
Expand Down Expand Up @@ -220,4 +221,4 @@ public String getNewNodeIdIfUnavailable( final String nodeId ) {
return newNodeId;
}

}
}