[DHCP] IPv6 Shared Network Support For Terraform Provider #282

VishrutiBuddhadev · 2025-11-27T10:11:32Z

No description provided.

…open#265) Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.43.0 to 0.45.0. - [Commits](golang/crypto@v0.43.0...v0.45.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-version: 0.45.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…nios into ipv6_shared_network

unasra · 2025-12-01T05:01:27Z

examples/data-sources/nios_dhcp_ipv6sharednetwork/data-source.tf

@@ -0,0 +1,16 @@
+// Retrieve a specific DHCP Ipv6 Shared Network by filters
+data "nios_dhcp_ipv6sharednetwork" "get_dhcp_ipv6sharednetwork_using_filters" {


Missing .md files
Please run go generate and amend folder name if required !

unasra · 2025-12-01T05:01:38Z

examples/data-sources/nios_dhcp_ipv6sharednetwork/data-source.tf

@@ -0,0 +1,16 @@
+// Retrieve a specific DHCP Ipv6 Shared Network by filters


Suggested change

// Retrieve a specific DHCP Ipv6 Shared Network by filters

// Retrieve a specific DHCP IPv6 Shared Network by filters

Applies for all occurences

unasra · 2025-12-01T05:39:18Z

internal/service/dhcp/ipv6sharednetwork_data_source_test.go

+	network1 := acctest.RandomIPv6Network()
+	network2 := acctest.RandomIPv6Network()
+	networks := []map[string]any{
+		{"ref": "${nios_ipam_ipv6network.test1.ref}"},


Using Expand and Flatten Wrappers , cant we eliminate the use of "ref" somehow and just keep a string array of networks ?

unasra · 2025-12-01T05:41:41Z

internal/service/dhcp/ipv6sharednetwork_resource.go

+// Ensure provider defined types fully satisfy framework interfaces.
+var _ resource.Resource = &Ipv6sharednetworkResource{}
+var _ resource.ResourceWithImportState = &Ipv6sharednetworkResource{}
+


var _ resource.ResourceWithValidateConfig = &Ipv6sharednetworkResource{}

unasra · 2025-12-01T07:45:55Z

internal/service/dhcp/model_ipv6sharednetwork.go

+		Default:             booldefault.StaticBool(false),
+		MarkdownDescription: "Determines whether an IPv6 shared network is disabled or not. When this is set to False, the IPv6 shared network is enabled.",
+	},
+	"domain_name": schema.StringAttribute{


IsValidFQDN required for this field ?

Case Insensitive String detected !
Or validation against upper case !

unasra · 2025-12-01T07:50:07Z

internal/service/dhcp/model_ipv6sharednetwork_options.go

+	"vendor_class": schema.StringAttribute{
+		Computed: true,
+		Optional: true,
+		Default:  stringdefault.StaticString("DHCP"),


Best not to keep a default for the field here !

unasra · 2025-12-01T07:57:09Z

internal/service/dhcp/model_ipv6sharednetwork.go

+		},
+		MarkdownDescription: "If this field is set to True, the DHCP server generates a hostname and updates DNS with it when the DHCP client request does not contain a hostname.",
+	},
+	"ddns_server_always_updates": schema.BoolAttribute{


ddns_use_option81 needs to be true for this field to work . Otherwise

Best add a validate Config

Addressed all the review comments

unasra · 2025-12-01T07:57:43Z

internal/service/dhcp/model_ipv6sharednetwork.go

+		},
+		MarkdownDescription: "Comment for the IPv6 shared network, maximum 256 characters.",
+	},
+	"ddns_domainname": schema.StringAttribute{


Case Insensitive String detected !
Or validation against upper case !

unasra · 2025-12-01T07:58:11Z

internal/service/dhcp/model_ipv6sharednetwork.go

+		Default:             booldefault.StaticBool(false),
+		MarkdownDescription: "Determines whether an IPv6 shared network is disabled or not. When this is set to False, the IPv6 shared network is enabled.",
+	},
+	"domain_name": schema.StringAttribute{


Case Insensitive String detected !
Or validation against upper case !

…IPv6 Fixed Address Template (infobloxopen#285) Co-authored-by: Ujjwal Nasra <[email protected]>

…s into ipv6_shared_network

…nios into ipv6_shared_network

Copilot

Pull request overview

This PR adds comprehensive support for IPv6 Shared Network resources and data sources to the Terraform NIOS provider, enabling management of DHCP IPv6 shared networks with extensive configuration options including DDNS settings, domain configurations, DHCP options, and extensible attributes.

Key Changes

Updates the infoblox-nios-go-client dependency to add Ipv6sharednetworkNetworks model with structured network references
Implements full CRUD operations for IPv6 shared networks with validation, import support, and extensible attributes handling
Adds comprehensive test coverage with 30+ test cases covering all configurable attributes and edge cases

Reviewed changes

Copilot reviewed 15 out of 20 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
vendor/modules.txt, go.mod, go.sum	Updates infoblox-nios-go-client dependency to version with IPv6 shared network support
vendor/.../model_ipv6sharednetwork_networks.go	New generated model for IPv6 shared network network references
vendor/.../model_ipv6sharednetwork.go	Updates Networks field from `[]string` to `[]Ipv6sharednetworkNetworks` for structured references
internal/utils/utils.go	Adds bounds checking to ExtractResourceRef to handle edge cases
internal/service/dhcp/model_ipv6sharednetwork.go	Implements core model with Expand/Flatten functions and network reference handling
internal/service/dhcp/model_ipv6sharednetwork_options.go	Implements DHCP options model with validation support
internal/service/dhcp/model_ipv6sharednetwork_logic_filter_rules.go	Implements logic filter rules model
internal/service/dhcp/ipv6sharednetwork_resource.go	Implements resource with CRUD operations, validation, and import support
internal/service/dhcp/ipv6sharednetwork_resource_test.go	Comprehensive test suite with 30+ test cases
internal/service/dhcp/ipv6sharednetwork_data_source.go	Implements data source with filtering and pagination
internal/service/dhcp/ipv6sharednetwork_data_source_test.go	Data source tests for filters and extensible attributes
internal/service/dhcp/model_ipv6fixedaddresstemplate.go	Adds Computed attribute to number_of_addresses and offset fields
internal/provider/provider.go	Registers new resource and data source
examples/ and docs/	Adds documentation and usage examples

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-01T11:31:51Z

internal/service/dhcp/ipv6sharednetwork_resource.go

+		// Check if ddns_use_option81 is set to false
+		if data.DdnsUseOption81.IsNull() && data.DdnsUseOption81.IsUnknown() && !data.DdnsUseOption81.ValueBool() {


Logic error in validation condition: The condition uses && (AND) when it should use || (OR). The current logic data.DdnsUseOption81.IsNull() && data.DdnsUseOption81.IsUnknown() && !data.DdnsUseOption81.ValueBool() can never be true because a value cannot be both null AND unknown AND have a false boolean value simultaneously. This should be data.DdnsUseOption81.IsNull() || data.DdnsUseOption81.IsUnknown() || !data.DdnsUseOption81.ValueBool() to properly check if ddns_use_option81 is not set to true.

Suggested change

// Check if ddns_use_option81 is set to false

if data.DdnsUseOption81.IsNull() && data.DdnsUseOption81.IsUnknown() && !data.DdnsUseOption81.ValueBool() {

// Check if ddns_use_option81 is not set to true

if data.DdnsUseOption81.IsNull() || data.DdnsUseOption81.IsUnknown() || !data.DdnsUseOption81.ValueBool() {

Copilot · 2025-12-01T11:31:52Z

internal/service/dhcp/ipv6sharednetwork_resource.go

+		}
+	}
+
+	var options []Ipv6fixedaddresstemplateOptionsModel


Wrong type used in variable declaration: The variable options is declared as []Ipv6fixedaddresstemplateOptionsModel but should be []Ipv6sharednetworkOptionsModel since this is in the IPv6 shared network resource validation. This type mismatch will cause incorrect behavior when accessing option fields.

Suggested change

var options []Ipv6fixedaddresstemplateOptionsModel

var options []Ipv6sharednetworkOptionsModel

Copilot · 2025-12-01T11:31:52Z

internal/service/dhcp/ipv6sharednetwork_resource_test.go

+					resource.TestCheckResourceAttrPair(resourceName, "networks.0.ref", "nios_ipam_ipv6network.test1", "ref"),
+					resource.TestCheckResourceAttrPair(resourceName, "networks.1.ref", "nios_ipam_ipv6network.test2", "ref"),


Test assertion mismatch: The test is checking for networks.0.ref and networks.1.ref which suggests the networks field contains objects with a ref property. However, based on the schema and model definition, networks is defined as a List of String (line 250-258 in model_ipv6sharednetwork.go), not a list of objects. The correct assertion should be checking the string values directly: resource.TestCheckResourceAttrPair(resourceName, "networks.0", "nios_ipam_ipv6network.test1", "ref") without the .ref suffix on the networks field.

Copilot · 2025-12-01T11:31:52Z

internal/service/dhcp/ipv6sharednetwork_resource_test.go

+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckIpv6sharednetworkExists(context.Background(), resourceName, &v),
+					resource.TestCheckResourceAttr(resourceName, "networks.#", "1"),
+					resource.TestCheckResourceAttrPair(resourceName, "networks.0.ref", "nios_ipam_ipv6network.test1", "ref"),


Test assertion mismatch: Same issue as lines 696-697. The test is checking networks.0.ref but networks is a list of strings, not a list of objects. The correct assertion should be resource.TestCheckResourceAttrPair(resourceName, "networks.0", "nios_ipam_ipv6network.test1", "ref") without the .ref suffix.

VishrutiBuddhadev and others added 4 commits November 26, 2025 14:20

generated files

94ab6f2

added tests and generated docs

0229f72

Merge branch 'feature' of github.com:infobloxopen/terraform-provider-…

611d262

…nios into ipv6_shared_network

VishrutiBuddhadev requested a review from unasra November 27, 2025 10:12

unasra reviewed Dec 1, 2025

View reviewed changes

rsharmaInfoblox and others added 7 commits December 1, 2025 14:49

NPA-1323: Added check for handling invalid ref (infobloxopen#284)

70af369

[DHCP][NPA - 1333] Resolve Inconsistent Offset and Address Count for …

3c12cfb

…IPv6 Fixed Address Template (infobloxopen#285) Co-authored-by: Ujjwal Nasra <[email protected]>

addressed review comments

05e61ee

wip

0a22b8d

addressed review comments

51a219c

Merge branch 'main' of github.com:infobloxopen/terraform-provider-nio…

3772b8b

…s into ipv6_shared_network

Merge branch 'feature' of github.com:infobloxopen/terraform-provider-…

74b878a

…nios into ipv6_shared_network

VishrutiBuddhadev requested review from Copilot and unasra December 1, 2025 11:19

Copilot started reviewing on behalf of VishrutiBuddhadev December 1, 2025 11:21 View session

Copilot finished reviewing on behalf of VishrutiBuddhadev December 1, 2025 11:22

Copilot AI reviewed Dec 1, 2025

View reviewed changes

addressed copilot's review comments

492b39a

		@@ -0,0 +1,16 @@
		// Retrieve a specific DHCP Ipv6 Shared Network by filters
		data "nios_dhcp_ipv6sharednetwork" "get_dhcp_ipv6sharednetwork_using_filters" {

		// Check if ddns_use_option81 is set to false
		if data.DdnsUseOption81.IsNull() && data.DdnsUseOption81.IsUnknown() && !data.DdnsUseOption81.ValueBool() {

	var options []Ipv6fixedaddresstemplateOptionsModel
	var options []Ipv6sharednetworkOptionsModel

		resource.TestCheckResourceAttrPair(resourceName, "networks.0.ref", "nios_ipam_ipv6network.test1", "ref"),
		resource.TestCheckResourceAttrPair(resourceName, "networks.1.ref", "nios_ipam_ipv6network.test2", "ref"),

[DHCP] IPv6 Shared Network Support For Terraform Provider #282

Are you sure you want to change the base?

[DHCP] IPv6 Shared Network Support For Terraform Provider #282

Uh oh!

Conversation

VishrutiBuddhadev commented Nov 27, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes

Reviewed changes

Uh oh!

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants