[FIX] NPA-1042 - Added Validation for Vdiscoverytask Port, Protocol, and DriverType Fields #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nios into npa-1042
…open#265) Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.43.0 to 0.45.0. - [Commits](golang/crypto@v0.43.0...v0.45.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-version: 0.45.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…nios into npa-1042
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds validation logic for the use_identity and allow_unsecured_connection fields in the vDiscovery Task resource to enforce specific configuration constraints.
- Enforces standard port requirements when
use_identityis true (port 443 for HTTPS, port 80 for HTTP) - Validates that
allow_unsecured_connectionrequires HTTPS protocol and either VMWARE or OPENSTACK driver types
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
VishrutiBuddhadev
changed the title
VishrutiBuddhadev
approved these changes
Dec 2, 2025
Chaithra001
pushed a commit
to Chaithra001/terraform-provider-nios
that referenced
this pull request
Dec 2, 2025
…and DriverType Fields (infobloxopen#279) * added validator for use_identity and allow_unsecured_connection attributes * modified comment * chore(deps): bump golang.org/x/crypto from 0.43.0 to 0.45.0 (infobloxopen#265) Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.43.0 to 0.45.0. - [Commits](golang/crypto@v0.43.0...v0.45.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-version: 0.45.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Vishruti Buddhadev <[email protected]>
VishrutiBuddhadev
added a commit
to VishrutiBuddhadev/terraform-provider-nios
that referenced
this pull request
Dec 3, 2025
…and DriverType Fields (infobloxopen#279) * added validator for use_identity and allow_unsecured_connection attributes * modified comment * chore(deps): bump golang.org/x/crypto from 0.43.0 to 0.45.0 (infobloxopen#265) Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.43.0 to 0.45.0. - [Commits](golang/crypto@v0.43.0...v0.45.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-version: 0.45.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Vishruti Buddhadev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.