NPA-1227: Resource and DataSource for RPZ PTR Record #278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsharmaInfoblox
requested review from
JkhatriInfobox,
VishrutiBuddhadev and
unasra
…e-and-datasource-for-rpz-ptr
unasra
reviewed
Dec 1, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request implements a new resource and data source for managing RPZ (Response Policy Zone) PTR records in Infoblox NIOS. The PR adds support for creating, reading, updating, and deleting RPZ PTR records, which are used for DNS response policy management. The implementation follows the existing pattern established by the RPZ A record resource already in the codebase.
Key Changes
- Added two new custom validators (
IsValidArpaIPv4RPZandIsValidArpaIPv6RPZ) to validate RPZ-specific ARPA format addresses that include the RPZ zone suffix - Implemented the
nios_rpz_record_ptrresource with comprehensive CRUD operations, supporting multiple addressing modes (IPv4, IPv6, or custom name) - Added the
nios_rpz_record_ptrdata source with filtering capabilities by standard attributes and extensible attributes
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/validator/ipv4_arpa_rpz_validator.go | New validator for IPv4 ARPA addresses in RPZ format, validating the pattern x.x.x.x.in-addr.arpa.<rp-zone> |
| internal/validator/ipv6_arpa_rpz_validator.go | New validator for IPv6 ARPA addresses in RPZ format, validating the pattern x.x.x...x.ip6.arpa.<rp-zone> with 32 hex nibbles |
| internal/service/rpz/record_rpz_ptr_resource.go | Main resource implementation with CRUD operations, configuration validation, and import support |
| internal/service/rpz/model_record_rpz_ptr.go | Data model and schema definitions for the RPZ PTR record resource |
| internal/service/rpz/record_rpz_ptr_data_source.go | Data source implementation with pagination and filtering support |
| internal/service/rpz/record_rpz_ptr_resource_test.go | Comprehensive acceptance tests covering all resource attributes and operations |
| internal/service/rpz/record_rpz_ptr_data_source_test.go | Acceptance tests for data source filtering capabilities |
| internal/provider/provider.go | Registration of the new resource and data source with the provider |
| examples/resources/nios_rpz_record_ptr/resource.tf | Example configurations demonstrating various use cases |
| examples/data-sources/nios_rpz_record_ptr/data-source.tf | Example data source queries |
| docs/resources/rpz_record_ptr.md | Generated documentation for the resource |
| docs/data-sources/rpz_record_ptr.md | Generated documentation for the data source |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
unasra
reviewed
Dec 1, 2025
unasra
reviewed
Dec 2, 2025
Collaborator
unasra
left a comment
unasra
left a comment
There was a problem hiding this comment.
LGTM
@JchhatbarInfoblox Please take a look !
unasra
changed the title
Collaborator
|
@rsharmaInfoblox Please resolve the conflicts. |
…e-and-datasource-for-rpz-ptr
…e-and-datasource-for-rpz-ptr
…e-and-datasource-for-rpz-ptr
Chaithra001
pushed a commit
to Chaithra001/terraform-provider-nios
that referenced
this pull request
Dec 2, 2025
* NPA-1227: added resource and data source for rpz ptr record * NPA-1227: added fix for sending rp_zone in update req because of wapi behavior * NPA-1227: removed duplicate parent zone func * NPA-1227: fixed some markdown desc comments and cosmetic changes * NPA-1227: used exactly one of validator instead of validate config for name, ipv4 and ipv6 presence * NPA-1227: added base func for custom view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resource and DataSource for rpz ptr record