[DHCP] Terraform Provider Support for IPV6 Fixed address #277
Conversation
VishrutiBuddhadev
left a comment
VishrutiBuddhadev
left a comment
There was a problem hiding this comment.
Please modify model_func_call.go for ipam to contain these plan modifiers
| @@ -0,0 +1,16 @@ | |||
| // Retrieve a specific IPV6 Fixed Addresses by filters | |||
There was a problem hiding this comment.
| // Retrieve a specific IPV6 Fixed Addresses by filters | |
| // Retrieve a specific IPV6 Fixed Address by filters |
| @@ -0,0 +1,114 @@ | |||
| // Create an IPV6 Network (Required as Parent) | |||
There was a problem hiding this comment.
Can we create a single IPV6 network as Parent and use it in all the examples ?
| comment = "Parent network for DHCP fixed addresses" | ||
| } | ||
|
|
||
| // Create an IPV6 Fixed Address with Basic Fields |
There was a problem hiding this comment.
| // Create an IPV6 Fixed Address with Basic Fields | |
| // Create an IPv6 Fixed Address with Basic Fields |
Please make this change for all the examples and the resource and data source descriptions
| extattrs = { | ||
| Site = "location-2" | ||
| } | ||
| depends_on = [nios_ipam_ipv6network.parent_network1] |
There was a problem hiding this comment.
network = nios_ipam_ipv6network.parent_network1.network can be used here to create implicit dependency instead of depends_on
| use_logic_filter_rules = true | ||
| logic_filter_rules = [ | ||
| { | ||
| filter = "ipv6_option_filter" |
There was a problem hiding this comment.
ipv6_option_filter rule object has to be present on the grid for this.
I think as of now it can be removed from the additional fields
| ipv6addr := "2001:db8:abcd:1231::1" | ||
| networkView := acctest.RandomNameWithPrefix("network-view") | ||
| duid := "00:01:00:01:1d:2b:3c:4d:00:0c:29:ab:cd:ef" | ||
| domainName1 := acctest.RandomName() |
There was a problem hiding this comment.
Please give domain name in fqdn format
| domainName1 := acctest.RandomName() | |
| domainName1 := acctest.RandomName()+".com" |
| ipv6addr := "2001:db8:abcd:1231::1" | ||
| networkView := acctest.RandomNameWithPrefix("network-view") | ||
| duid := "00:01:00:01:1d:2b:3c:4d:00:0c:29:ab:cd:ef" | ||
| domainNameServers1 := `["2001:4860:4860::8888","2001:4860:4860::8844"]` |
There was a problem hiding this comment.
Please pass this as []string{} and not string
| return strings.Join([]string{testAccBaseNetworkView(networkView, ipv6Network), config}, "") | ||
| } | ||
|
|
||
| func testAccBaseNetworkViewCreateTwoNetworks(networkView, ipv6Network1, ipv6Network2 string) string { |
There was a problem hiding this comment.
| func testAccBaseNetworkViewCreateTwoNetworks(networkView, ipv6Network1, ipv6Network2 string) string { | |
| func testAccBaseWithTwoIPv6Networks(networkView, ipv6Network1, ipv6Network2 string) string { |
| options := []map[string]any{ | ||
| { | ||
| "name": "domain-name", | ||
| "num": "15", |
There was a problem hiding this comment.
Could you add multiple options here ?
Also vary the options with just providing name or num
| "domain-name, broadcast-address, broadcast-address-offset, dhcp-lease-time, dhcp6.name-servers.", | ||
| optionName), | ||
| ) | ||
| } |
There was a problem hiding this comment.
Please check if this validation is required here
2 participants
No description provided.